Page MenuHomePhabricator

[GVN] Refactor analyzeLoadFromClobberingWrite to simplify code
ClosedPublic

Authored by ksyx on Mar 31 2021, 3:43 AM.

Details

Summary

This change adjusts the order of two swappable if statements to make code cleaner.

Diff Detail

Event Timeline

ksyx created this revision.Mar 31 2021, 3:43 AM
ksyx requested review of this revision.Mar 31 2021, 3:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 31 2021, 3:43 AM
lattner accepted this revision.Mar 31 2021, 10:13 AM

nice thanks

This revision is now accepted and ready to land.Mar 31 2021, 10:13 AM
nikic added a subscriber: nikic.Mar 31 2021, 11:13 AM
nikic added inline comments.
llvm/lib/Transforms/Utils/VNCoercion.cpp
191–192

You may want to move this comment down, as it belongs to the moved condition.

ksyx marked an inline comment as done.Mar 31 2021, 4:11 PM
This revision was landed with ongoing or failed builds.Mar 31 2021, 5:40 PM
This revision was automatically updated to reflect the committed changes.