Page MenuHomePhabricator

[libcxx] Make the GDB pretty printer test less strict
ClosedPublic

Authored by phosek on Mar 29 2021, 12:20 PM.

Details

Summary

This is a workaround for PR48937. GDB can sometimes print additional
warnings which currently fails the test. Use re.search instead of
re.match to ignore this additional output.

Diff Detail

Event Timeline

phosek requested review of this revision.Mar 29 2021, 12:20 PM
phosek created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 29 2021, 12:20 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript

I think it'd be better to actually address the RTTI issue in PR48937, but this can be used as a temporary workaround.

ldionne resigned from this revision.Tue, Apr 13, 7:31 AM
ldionne added a reviewer: saugustine.

I defer my review to the author of those pretty printers.

saugustine accepted this revision.Thu, Apr 15, 4:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Apr 15, 11:34 PM
This revision was automatically updated to reflect the committed changes.