[LLDB] Fix cleanup error in TestVSCode_disconnect.test_launch

[omjavaid]

Summary

TestVSCode_disconnect.test_launch fails with clean up error because disconnect gets called twice once from the test case and once from the tear down hook.

This patch disables disconnect after its been called from the test_launch

[clayborg]

Thanks for looking into this!

lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py

class VSCodeTestCaseBase(TestBase):
 
 
     def build_and_launch(self, program, args=None, cwd=None, env=None,
                          stopOnEntry=False, disableASLR=True,
                          disableSTDIO=False, shellExpandArguments=False,
                          trace=False, initCommands=None, preRunCommands=None,
                          stopCommands=None, exitCommands=None,
                          terminateCommands=None, sourcePath=None,
-                         debuggerRoot=None, runInTerminal=False):
+                         debuggerRoot=None, runInTerminal=False,
+                         disconnectAutomatically=True):
         '''Build the default Makefile target, create the VSCode debug adaptor,
            and launch the process.
         '''
         self.build_and_create_debug_adaptor()
         self.assertTrue(os.path.exists(program), 'executable must exist')
 
         return self.launch(program, args, cwd, env, stopOnEntry, disableASLR,
                     disableSTDIO, shellExpandArguments, trace,
                     initCommands, preRunCommands, stopCommands, exitCommands,
-                    terminateCommands, sourcePath, debuggerRoot, runInTerminal=runInTerminal)
+                    terminateCommands, sourcePath, debuggerRoot, runInTerminal=runInTerminal,
+                    disconnectAutomatically=disconnectAutomatically)

lldb/test/API/tools/lldb-vscode/disconnect/TestVSCode_disconnect.py

class TestVSCode_launch(lldbvscode_testcase.VSCodeTestCaseBase):
     @skipIf(oslist=["linux"], archs=["arm"])
     def test_launch(self):
         """
             This test launches a process that would creates a file, but we disconnect
             before the file is created, which terminates the process and thus the file is not
             created.
         """
         program = self.getBuildArtifact("a.out")
-        self.build_and_launch(program)
+        self.build_and_launch(program, disconnectAutomatically=False)
 
         # We set a breakpoint right before the side effect file is created
         self.set_source_breakpoints(self.source, [line_number(self.source, '// breakpoint')])
         self.continue_to_next_stop()
 
         self.vscode.request_disconnect()
         # verify we didn't produce the side effect file
         time.sleep(1)