Page MenuHomePhabricator

[LLDB] Fix cleanup error in TestVSCode_disconnect.test_launch
ClosedPublic

Authored by omjavaid on Mar 29 2021, 2:38 AM.

Details

Summary

TestVSCode_disconnect.test_launch fails with clean up error because disconnect gets called twice once from the test case and once from the tear down hook.

This patch disables disconnect after its been called from the test_launch

Diff Detail

Unit TestsFailed

TimeTest
25,300 msx64 debian > LLVM.Bindings/Go::go.test
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/bin/llvm-go go=/usr/bin/go test llvm.org/llvm/bindings/go/llvm

Event Timeline

omjavaid requested review of this revision.Mar 29 2021, 2:38 AM
omjavaid created this revision.
clayborg accepted this revision.Mar 29 2021, 10:55 AM

Thanks for looking into this!

This revision is now accepted and ready to land.Mar 29 2021, 10:55 AM
This revision was landed with ongoing or failed builds.Mar 30 2021, 3:37 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2021, 3:37 AM