Page MenuHomePhabricator

[clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs
ClosedPublic

Authored by leonardchan on Mar 25 2021, 11:38 AM.

Diff Detail

Event Timeline

leonardchan created this revision.Mar 25 2021, 11:38 AM
leonardchan requested review of this revision.Mar 25 2021, 11:38 AM
phosek accepted this revision.Mar 28 2021, 11:06 PM

LGTM although I'm becoming worried about the impact on build times given the rapidly increasing number of multilib variants.

This revision is now accepted and ready to land.Mar 28 2021, 11:06 PM

Update to remove instrumentation on globals. It's likel we may not need the hwasan+relative-vtables multilibs when the next clang roll comes around.

phosek added inline comments.Fri, Jul 30, 6:43 PM
clang/cmake/caches/Fuchsia-stage2.cmake
234

I missed this earlier, but this isn't going to work since the variable isn't populated, you're going to need ${FUCHSIA_aarch64-unknown-fuchsia+hwasan_COMPILER_FLAGS} here.

234

Could we set this in the backend when targeting Fuchsia and avoid the having to pass the flag manually?

243

Ditto