This is an archive of the discontinued LLVM Phabricator instance.

Differential D99364

[clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs
ClosedPublic

Authored by leonardchan on Mar 25 2021, 11:38 AM.

Details

Reviewers
phosek
mcgrathr
Commits
rGe2ff880a7ed4: [clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs
rGbb438f6cbfc0: [clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs

Diff Detail

Event Timeline

leonardchan created this revision.Mar 25 2021, 11:38 AM
Herald added a subscriber: mgorny. · View Herald TranscriptMar 25 2021, 11:38 AM
leonardchan requested review of this revision.Mar 25 2021, 11:38 AM
Harbormaster completed remote builds in B95747: Diff 333377.Mar 25 2021, 1:24 PM
phosek accepted this revision.Mar 28 2021, 11:06 PM

LGTM although I'm becoming worried about the impact on build times given the rapidly increasing number of multilib variants.

This revision is now accepted and ready to land.Mar 28 2021, 11:06 PM
leonardchan updated this revision to Diff 349700.Jun 3 2021, 2:55 PM

Update to remove instrumentation on globals. It's likel we may not need the hwasan+relative-vtables multilibs when the next clang roll comes around.

Harbormaster completed remote builds in B107562: Diff 349700.Jun 3 2021, 4:06 PM
Closed by commit rGbb438f6cbfc0: [clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs (authored by leonardchan). · Explain WhyJul 30 2021, 11:53 AM
This revision was automatically updated to reflect the committed changes.
leonardchan added a commit: rGbb438f6cbfc0: [clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs.
phosek added inline comments.Jul 30 2021, 6:43 PM
clang/cmake/caches/Fuchsia-stage2.cmake
234

I missed this earlier, but this isn't going to work since the variable isn't populated, you're going to need ${FUCHSIA_aarch64-unknown-fuchsia+hwasan_COMPILER_FLAGS} here.

234

Could we set this in the backend when targeting Fuchsia and avoid the having to pass the flag manually?

243

Ditto

phosek added a reverting change: rGa9d1970384aa: Revert "[clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs".Jul 30 2021, 6:57 PM
leonardchan added a commit: rGe2ff880a7ed4: [clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs.Aug 10 2021, 10:53 AM

Revision Contents

PathSize
clang/
cmake/
caches/
21 lines

Diff 363173

clang/cmake/caches/Fuchsia-stage2.cmake

Show First 20 Lines • Show All 220 Lines • ▼ Show 20 Lines foreach(target x86_64-unknown-fuchsia;aarch64-unknown-fuchsia)
set(RUNTIMES_${target}+asan+noexcept_LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS OFF CACHE BOOL "") set(RUNTIMES_${target}+asan+noexcept_LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS OFF CACHE BOOL "")
set(RUNTIMES_${target}+asan+noexcept_LIBCXXABI_ENABLE_EXCEPTIONS OFF CACHE BOOL "") set(RUNTIMES_${target}+asan+noexcept_LIBCXXABI_ENABLE_EXCEPTIONS OFF CACHE BOOL "")
set(RUNTIMES_${target}+asan+noexcept_LIBCXX_ENABLE_EXCEPTIONS OFF CACHE BOOL "") set(RUNTIMES_${target}+asan+noexcept_LIBCXX_ENABLE_EXCEPTIONS OFF CACHE BOOL "")
# Use .build-id link. # Use .build-id link.
list(APPEND RUNTIME_BUILD_ID_LINK "${target}") list(APPEND RUNTIME_BUILD_ID_LINK "${target}")
endforeach() endforeach()
set(LLVM_RUNTIME_MULTILIBS "asan;noexcept;compat;asan+noexcept" CACHE STRING "") # HWAsan
set(RUNTIMES_aarch64-unknown-fuchsia+hwasan_LLVM_BUILD_COMPILER_RT OFF CACHE BOOL "")
set(RUNTIMES_aarch64-unknown-fuchsia+hwasan_LLVM_USE_SANITIZER "HWAddress" CACHE STRING "")
set(RUNTIMES_aarch64-unknown-fuchsia+hwasan_LIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS OFF CACHE BOOL "")
set(RUNTIMES_aarch64-unknown-fuchsia+hwasan_LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS OFF CACHE BOOL "")
set(RUNTIMES_aarch64-unknown-fuchsia+hwasan_CMAKE_CXX_FLAGS "${RUNTIMES_aarch64-unknown-fuchsia+hwasan_CMAKE_CXX_FLAGS} -mllvm --hwasan-globals=0" CACHE STRING "")
phosekUnsubmitted
Not Done
ReplyInline Actions

I missed this earlier, but this isn't going to work since the variable isn't populated, you're going to need ${FUCHSIA_aarch64-unknown-fuchsia+hwasan_COMPILER_FLAGS} here.

phosek: I missed this earlier, but this isn't going to work since the variable isn't populated, you're…
phosekUnsubmitted
Not Done
ReplyInline Actions

Could we set this in the backend when targeting Fuchsia and avoid the having to pass the flag manually?

phosek: Could we set this in the backend when targeting Fuchsia and avoid the having to pass the flag…
# HWASan+noexcept
set(RUNTIMES_aarch64-unknown-fuchsia+hwasan+noexcept_LLVM_BUILD_COMPILER_RT OFF CACHE BOOL "")
set(RUNTIMES_aarch64-unknown-fuchsia+hwasan+noexcept_LLVM_USE_SANITIZER "HWAddress" CACHE STRING "")
set(RUNTIMES_aarch64-unknown-fuchsia+hwasan+noexcept_LIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS OFF CACHE BOOL "")
set(RUNTIMES_aarch64-unknown-fuchsia+hwasan+noexcept_LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS OFF CACHE BOOL "")
set(RUNTIMES_aarch64-unknown-fuchsia+hwasan+noexcept_LIBCXXABI_ENABLE_EXCEPTIONS OFF CACHE BOOL "")
set(RUNTIMES_aarch64-unknown-fuchsia+hwasan+noexcept_LIBCXX_ENABLE_EXCEPTIONS OFF CACHE BOOL "")
set(RUNTIMES_aarch64-unknown-fuchsia+hwasan+noexcept_CMAKE_CXX_FLAGS "${RUNTIMES_aarch64-unknown-fuchsia+hwasan+noexcept_CMAKE_CXX_FLAGS} -mllvm --hwasan-globals=0" CACHE STRING "")
phosekUnsubmitted
Not Done
ReplyInline Actions

Ditto

phosek: Ditto
set(LLVM_RUNTIME_MULTILIBS "asan;noexcept;compat;asan+noexcept;hwasan;hwasan+noexcept" CACHE STRING "")
set(LLVM_RUNTIME_MULTILIB_asan_TARGETS "x86_64-unknown-fuchsia;aarch64-unknown-fuchsia" CACHE STRING "") set(LLVM_RUNTIME_MULTILIB_asan_TARGETS "x86_64-unknown-fuchsia;aarch64-unknown-fuchsia" CACHE STRING "")
set(LLVM_RUNTIME_MULTILIB_noexcept_TARGETS "x86_64-unknown-fuchsia;aarch64-unknown-fuchsia" CACHE STRING "") set(LLVM_RUNTIME_MULTILIB_noexcept_TARGETS "x86_64-unknown-fuchsia;aarch64-unknown-fuchsia" CACHE STRING "")
set(LLVM_RUNTIME_MULTILIB_compat_TARGETS "x86_64-unknown-fuchsia;aarch64-unknown-fuchsia" CACHE STRING "") set(LLVM_RUNTIME_MULTILIB_compat_TARGETS "x86_64-unknown-fuchsia;aarch64-unknown-fuchsia" CACHE STRING "")
set(LLVM_RUNTIME_MULTILIB_asan+noexcept_TARGETS "x86_64-unknown-fuchsia;aarch64-unknown-fuchsia" CACHE STRING "") set(LLVM_RUNTIME_MULTILIB_asan+noexcept_TARGETS "x86_64-unknown-fuchsia;aarch64-unknown-fuchsia" CACHE STRING "")
set(LLVM_RUNTIME_MULTILIB_hwasan_TARGETS "aarch64-unknown-fuchsia" CACHE STRING "")
set(LLVM_RUNTIME_MULTILIB_hwasan+noexcept_TARGETS "aarch64-unknown-fuchsia" CACHE STRING "")
endif() endif()
set(LLVM_BUILTIN_TARGETS "${BUILTIN_TARGETS}" CACHE STRING "") set(LLVM_BUILTIN_TARGETS "${BUILTIN_TARGETS}" CACHE STRING "")
set(LLVM_RUNTIME_TARGETS "${RUNTIME_TARGETS}" CACHE STRING "") set(LLVM_RUNTIME_TARGETS "${RUNTIME_TARGETS}" CACHE STRING "")
# Setup toolchain. # Setup toolchain.
set(LLVM_INSTALL_TOOLCHAIN_ONLY ON CACHE BOOL "") set(LLVM_INSTALL_TOOLCHAIN_ONLY ON CACHE BOOL "")
set(LLVM_TOOLCHAIN_TOOLS set(LLVM_TOOLCHAIN_TOOLS
▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines