This is an archive of the discontinued LLVM Phabricator instance.

[LLD] Fix probing a MSYS based 'tar' in a Windows Container
ClosedPublic

Authored by mstorsjo on Mar 24 2021, 3:15 PM.

Details

Summary

Don't run the 'tar' tool in a cleared environment with only the
LANG variable set, just set LANG on top of the existing environment.

If the 'tar' tool is an MSYS based tool, running it in a Windows
Container hangs if all environment variables are cleared - in
particular, the USERPROFILE variable needs to be kept intact.

This is the same issue fixed as was fixed in other places in
9de63b2e051cb3e79645cc20b83b4d33d132cba0, but contrary to running
the actual tests, running with an as-cleared-as-possible environment
here is less important.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Mar 24 2021, 3:15 PM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2021, 3:15 PM
rnk accepted this revision.Mar 24 2021, 3:24 PM

lgtm

This revision is now accepted and ready to land.Mar 24 2021, 3:24 PM
MaskRay accepted this revision.Mar 24 2021, 9:59 PM