This is an archive of the discontinued LLVM Phabricator instance.

Differential D99120

[lldb] Silence GCC warnings about format not being a string literal in LLDB_SCOPED_TIMER
ClosedPublic

Authored by mstorsjo on Mar 22 2021, 3:12 PM.

Details

Reviewers
labath
dblaikie
JDevlieghere
Commits
rG2f18e51d8b9e: [lldb] Silence GCC warnings about format not being a string literal in…
Summary

Pass "%s" as the format string literal and LLVM_PRETTY_FUNCTION as
argument to it.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Mar 22 2021, 3:12 PM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2021, 3:12 PM
dblaikie accepted this revision.Mar 22 2021, 3:20 PM
dblaikie added a subscriber: dblaikie.

Looks right to me

This revision is now accepted and ready to land.Mar 22 2021, 3:20 PM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptMar 22 2021, 3:20 PM
Harbormaster completed remote builds in B95102: Diff 332447.Mar 22 2021, 4:32 PM
JDevlieghere accepted this revision.Mar 22 2021, 5:03 PM

Thanks

This revision was landed with ongoing or failed builds.Mar 23 2021, 5:12 AM
Closed by commit rG2f18e51d8b9e: [lldb] Silence GCC warnings about format not being a string literal in… (authored by mstorsjo). · Explain Why
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG2f18e51d8b9e: [lldb] Silence GCC warnings about format not being a string literal in….
JDevlieghere mentioned this in rG564eb20e0dee: Revert "[lldb] Avoid format string in LLDB_SCOPED_TIMER".May 25 2021, 5:23 PM

Revision Contents

PathSize
lldb/
include/
lldb/
Utility/
2 lines

Diff 332632

lldb/include/lldb/Utility/Timer.h

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Linesprivate:
Timer(const Timer &) = delete; Timer(const Timer &) = delete;
const Timer &operator=(const Timer &) = delete; const Timer &operator=(const Timer &) = delete;
}; };
} // namespace lldb_private } // namespace lldb_private
#define LLDB_SCOPED_TIMER() \ #define LLDB_SCOPED_TIMER() \
static ::lldb_private::Timer::Category _cat(LLVM_PRETTY_FUNCTION); \ static ::lldb_private::Timer::Category _cat(LLVM_PRETTY_FUNCTION); \
::lldb_private::Timer _scoped_timer(_cat, LLVM_PRETTY_FUNCTION) ::lldb_private::Timer _scoped_timer(_cat, "%s", LLVM_PRETTY_FUNCTION)
#define LLDB_SCOPED_TIMERF(...) \ #define LLDB_SCOPED_TIMERF(...) \
static ::lldb_private::Timer::Category _cat(LLVM_PRETTY_FUNCTION); \ static ::lldb_private::Timer::Category _cat(LLVM_PRETTY_FUNCTION); \
::lldb_private::Timer _scoped_timer(_cat, __VA_ARGS__) ::lldb_private::Timer _scoped_timer(_cat, __VA_ARGS__)
#endif // LLDB_UTILITY_TIMER_H #endif // LLDB_UTILITY_TIMER_H