This is an archive of the discontinued LLVM Phabricator instance.

Differential D98880

[lldb] Move Apple simulators test targets under API
ClosedPublic

Authored by JDevlieghere on Mar 18 2021, 11:18 AM.

Details

Reviewers
teemperor
Commits
rG36335fe75369: [lldb] Move Apple simulators test targets under API
Summary

Move the Apple simulators test targets as they only matter for the API tests.

Diff Detail

Event Timeline

JDevlieghere created this revision.Mar 18 2021, 11:18 AM
Herald added a subscriber: mgorny. · View Herald TranscriptMar 18 2021, 11:18 AM
JDevlieghere requested review of this revision.Mar 18 2021, 11:18 AM
JDevlieghere updated this revision to Diff 331634.
Harbormaster completed remote builds in B94512: Diff 331631.Mar 18 2021, 12:49 PM
Harbormaster completed remote builds in B94513: Diff 331634.Mar 18 2021, 1:00 PM
teemperor accepted this revision.Mar 18 2021, 1:52 PM

LGTM, thanks!

This revision is now accepted and ready to land.Mar 18 2021, 1:52 PM
Closed by commit rG36335fe75369: [lldb] Move Apple simulators test targets under API (authored by JDevlieghere). · Explain WhyMar 18 2021, 1:55 PM
This revision was automatically updated to reflect the committed changes.
JDevlieghere added a commit: rG36335fe75369: [lldb] Move Apple simulators test targets under API.
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2021, 1:55 PM

Revision Contents

PathSize
lldb/
test/
API/
22 lines
23 lines

Diff 331681

lldb/test/API/CMakeLists.txt

Show First 20 Lines • Show All 161 Lines • ▼ Show 20 Lines
if (CMAKE_GENERATOR STREQUAL "Xcode") if (CMAKE_GENERATOR STREQUAL "Xcode")
# Xcode does not get the auto-generated targets. We need to create # Xcode does not get the auto-generated targets. We need to create
# check-lldb-api manually. # check-lldb-api manually.
add_lit_testsuite(check-lldb-api "Running lldb api test suite" add_lit_testsuite(check-lldb-api "Running lldb api test suite"
${CMAKE_CURRENT_BINARY_DIR} ${CMAKE_CURRENT_BINARY_DIR}
DEPENDS lldb-test-deps) DEPENDS lldb-test-deps)
endif() endif()
# Targets for running the test suite on the different Apple simulators.
add_lit_testsuite(check-lldb-simulator-ios
"Running lldb test suite on the iOS simulator"
${CMAKE_CURRENT_BINARY_DIR}
PARAMS "lldb-run-with-simulator=ios"
EXCLUDE_FROM_CHECK_ALL
DEPENDS lldb-test-deps)
add_lit_testsuite(check-lldb-simulator-watchos
"Running lldb test suite on the watchOS simulator"
${CMAKE_CURRENT_BINARY_DIR}
PARAMS "lldb-run-with-simulator=watchos"
EXCLUDE_FROM_CHECK_ALL
DEPENDS lldb-test-deps)
add_lit_testsuite(check-lldb-simulator-tvos
"Running lldb test suite on the tvOS simulator"
${CMAKE_CURRENT_BINARY_DIR}
PARAMS "lldb-run-with-simulator=tvos"
EXCLUDE_FROM_CHECK_ALL
DEPENDS lldb-test-deps)

lldb/test/CMakeLists.txt

Show First 20 Lines • Show All 214 Lines • ▼ Show 20 Linesadd_lit_testsuite(check-lldb-reproducers
"Running lldb test suite with reproducer replay" "Running lldb test suite with reproducer replay"
${CMAKE_CURRENT_BINARY_DIR}/API ${CMAKE_CURRENT_BINARY_DIR}/API
${CMAKE_CURRENT_BINARY_DIR}/Shell ${CMAKE_CURRENT_BINARY_DIR}/Shell
PARAMS "lldb-run-with-repro=replay" PARAMS "lldb-run-with-repro=replay"
EXCLUDE_FROM_CHECK_ALL EXCLUDE_FROM_CHECK_ALL
DEPENDS lldb-test-deps) DEPENDS lldb-test-deps)
add_dependencies(check-lldb-reproducers check-lldb-reproducers-capture) add_dependencies(check-lldb-reproducers check-lldb-reproducers-capture)
# Targets for running the test suite on the different Apple simulators.
add_lit_testsuite(check-lldb-simulator-ios
"Running lldb test suite on the iOS simulator"
${CMAKE_CURRENT_BINARY_DIR}/API
PARAMS "lldb-run-with-simulator=ios"
EXCLUDE_FROM_CHECK_ALL
DEPENDS lldb-test-deps)
add_lit_testsuite(check-lldb-simulator-watchos
"Running lldb test suite on the watchOS simulator"
${CMAKE_CURRENT_BINARY_DIR}/API
PARAMS "lldb-run-with-simulator=watchos"
EXCLUDE_FROM_CHECK_ALL
DEPENDS lldb-test-deps)
add_lit_testsuite(check-lldb-simulator-tvos
"Running lldb test suite on the tvOS simulator"
${CMAKE_CURRENT_BINARY_DIR}/API
PARAMS "lldb-run-with-simulator=tvos"
EXCLUDE_FROM_CHECK_ALL
DEPENDS lldb-test-deps)
if(LLDB_BUILT_STANDALONE) if(LLDB_BUILT_STANDALONE)
# This has to happen *AFTER* add_lit_testsuite. # This has to happen *AFTER* add_lit_testsuite.
if (EXISTS ${LLVM_MAIN_SRC_DIR}/utils/llvm-lit) if (EXISTS ${LLVM_MAIN_SRC_DIR}/utils/llvm-lit)
# LLVM's make_paths_relative uses Python3_EXECUTABLE which isn't set in a # LLVM's make_paths_relative uses Python3_EXECUTABLE which isn't set in a
# standalone LLDB build. # standalone LLDB build.
set(Python3_EXECUTABLE ${Python3_EXECUTABLE}) set(Python3_EXECUTABLE ${Python3_EXECUTABLE})
add_subdirectory(${LLVM_MAIN_SRC_DIR}/utils/llvm-lit ${CMAKE_CURRENT_BINARY_DIR}/llvm-lit) add_subdirectory(${LLVM_MAIN_SRC_DIR}/utils/llvm-lit ${CMAKE_CURRENT_BINARY_DIR}/llvm-lit)
endif() endif()
endif() endif()