This is an archive of the discontinued LLVM Phabricator instance.

Differential D98639

Mark Bazel proposal as accepted
ClosedPublic

Authored by GMNGeoffrey on Mar 15 2021, 10:46 AM.

Details

Reviewers
beanz
lattner
Commits
rW8c509e6b770e: Mark Bazel proposal as accepted
Summary

This proposal has been reviewed and accepted.

Diff Detail

Repository
rW llvm-www

Event Timeline

GMNGeoffrey requested review of this revision.Mar 15 2021, 10:46 AM
GMNGeoffrey created this revision.
Harbormaster completed remote builds in B93853: Diff 330722.Mar 15 2021, 10:46 AM
GMNGeoffrey added reviewers: beanz, lattner.Mar 15 2021, 10:46 AM
beanz accepted this revision.Mar 15 2021, 11:45 AM

LGTM. I should have updated that in my patch.

This revision is now accepted and ready to land.Mar 15 2021, 11:45 AM
Closed by commit rW8c509e6b770e: Mark Bazel proposal as accepted (authored by GMNGeoffrey). · Explain WhyMar 15 2021, 11:59 AM
This revision was automatically updated to reflect the committed changes.
GMNGeoffrey added a commit: rW8c509e6b770e: Mark Bazel proposal as accepted.

Revision Contents

PathSize
proposals/
2 lines

Diff 330754

proposals/LP0002-BazelBuildConfiguration.md

# Add Bazel Build Configuration to the LLVM Monorepo # Add Bazel Build Configuration to the LLVM Monorepo
* Proposal: * Proposal:
[LP-0002](https://github.com/llvm/llvm-www/blob/master/proposals/LP0002-BazelBuildConfiguration.md) [LP-0002](https://github.com/llvm/llvm-www/blob/master/proposals/LP0002-BazelBuildConfiguration.md)
* Author: [Geoffrey Martin-Noble](https://github.com/gmngeoffrey) * Author: [Geoffrey Martin-Noble](https://github.com/gmngeoffrey)
* Review Managers: [Chris Bieneman](https://github.com/thegreatbeanz), * Review Managers: [Chris Bieneman](https://github.com/thegreatbeanz),
[Eric Christopher](https://github.com/echristo), [Eric Christopher](https://github.com/echristo),
[Renato Golin](https://github.com/rengolin), [Renato Golin](https://github.com/rengolin),
[Chris Lattner](https://github.com/lattner), [Chris Lattner](https://github.com/lattner),
[Geoffrey Martin-Noble](https://github.com/gmngeoffrey), [Geoffrey Martin-Noble](https://github.com/gmngeoffrey),
[Tom Stellard](https://github.com/tstellar) [Tom Stellard](https://github.com/tstellar)
* Status: Active review (2021-02-09...2021-02-23) * Status: Accepted
* Proposal thread: * Proposal thread:
[thread](https://lists.llvm.org/pipermail/llvm-dev/2021-February/148437.html) [thread](https://lists.llvm.org/pipermail/llvm-dev/2021-February/148437.html)
* Pitch thread: * Pitch thread:
[thread](https://lists.llvm.org/pipermail/llvm-dev/2021-January/147745.html) [thread](https://lists.llvm.org/pipermail/llvm-dev/2021-January/147745.html)
* Previous Discussions * Previous Discussions
[1](http://lists.llvm.org/pipermail/llvm-dev/2020-October/146138.html), [1](http://lists.llvm.org/pipermail/llvm-dev/2020-October/146138.html),
[2](http://lists.llvm.org/pipermail/llvm-dev/2020-November/146670.html) [2](http://lists.llvm.org/pipermail/llvm-dev/2020-November/146670.html)
▲ Show 20 Lines • Show All 316 Lines • Show Last 20 Lines