This is an archive of the discontinued LLVM Phabricator instance.

Differential D98593

[OCaml][test] Fix Bindings/OCaml/executionengine.ml test
ClosedPublic

Authored by jberdine on Mar 13 2021, 4:29 PM.

Details

Reviewers
whitequark
vaivaswatha
liuz
Commits
rG5bb2757e218d: [OCaml][test] Fix Bindings/OCaml/executionengine.ml test
Summary

It seems that at some point it became necessary to pass -thread to
the ocaml compiler for this test.

Diff Detail

Event Timeline

jberdine requested review of this revision.Mar 13 2021, 4:29 PM
jberdine created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2021, 4:29 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B93689: Diff 330483.Mar 13 2021, 5:08 PM
vaivaswatha accepted this revision.Mar 13 2021, 7:49 PM
This revision is now accepted and ready to land.Mar 13 2021, 7:49 PM
jberdine updated this revision to Diff 330815.Mar 15 2021, 2:42 PM
jberdine edited the summary of this revision. (Show Details)

rebase and trim unnecessary detail from commit summary

jberdine added a comment.Mar 15 2021, 2:44 PM

Now all tests run by ninja check-llvm-bindings-ocaml pass.

jberdine mentioned this in D98578: [OCaml] Add missing TypeKinds, Opcode, and AtomicRMWBinOps.Mar 15 2021, 2:51 PM
Harbormaster completed remote builds in B93922: Diff 330815.Mar 15 2021, 4:46 PM
Closed by commit rG5bb2757e218d: [OCaml][test] Fix Bindings/OCaml/executionengine.ml test (authored by jberdine). · Explain WhyMar 15 2021, 7:50 PM
This revision was automatically updated to reflect the committed changes.
jberdine added a commit: rG5bb2757e218d: [OCaml][test] Fix Bindings/OCaml/executionengine.ml test.

Revision Contents

PathSize
llvm/
test/
Bindings/
OCaml/
4 lines

Diff 330815

llvm/test/Bindings/OCaml/executionengine.ml

(* RUN: rm -rf %t && mkdir -p %t && cp %s %t/executionengine.ml (* RUN: rm -rf %t && mkdir -p %t && cp %s %t/executionengine.ml
* RUN: %ocamlc -g -w +A -package llvm.executionengine -linkpkg %t/executionengine.ml -o %t/executable * RUN: %ocamlc -g -w +A -thread -package llvm.executionengine -linkpkg %t/executionengine.ml -o %t/executable
* RUN: %t/executable * RUN: %t/executable
* RUN: %ocamlopt -g -w +A -package llvm.executionengine -linkpkg %t/executionengine.ml -o %t/executable * RUN: %ocamlopt -g -w +A -thread -package llvm.executionengine -linkpkg %t/executionengine.ml -o %t/executable
* RUN: %t/executable * RUN: %t/executable
* REQUIRES: native * REQUIRES: native
* XFAIL: vg_leak * XFAIL: vg_leak
*) *)
open Llvm open Llvm
open Llvm_executionengine open Llvm_executionengine
open Llvm_target open Llvm_target
▲ Show 20 Lines • Show All 100 Lines • Show Last 20 Lines