[OCaml] Add missing TypeKinds, Opcode, and AtomicRMWBinOps

[jberdine]

Summary

There are several enum values that have been added to LLVM-C that are
missing from the OCaml bindings. The types defined in
bindings/ocaml/llvm/llvm.ml should be in sync with the corresponding
enum definitions in include/llvm-c/Core.h. The enum values are passed
from C to OCaml unmodified, and clients of the OCaml bindings
interpret them as tags of the corresponding OCaml types. So the only
changes needed are to add the missing constructors to the type
definitions, and to change the name of the maximum opcode in an
assertion.

[jberdine]

For reference, ninja check-all with this diff on my system passes all but 2 seemingly unrelated tests. (I don't know why it is complaining about macos SDK versions and -lSystem).

----------------------------------------------------------------------
Ran 126 tests in 3.332s

OK
[647/648] Running all regression tests
llvm-lit: /Users/jjb/sat/sledge/.llvm_build/sledge/bin/../../../llvm-project/llvm/utils/lit/lit/llvm/config.py:345: note: using clang: /Users/jjb/sat/sledge/.llvm_build/sledge/bin/clang
llvm-lit: /Users/jjb/sat/sledge/.llvm_build/sledge/bin/../../../llvm-project/llvm/utils/lit/lit/util.py:408: note: using SDKROOT: '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk'
FAIL: LLVM-Unit :: Support/./SupportTests/HostTest.getMacOSHostVersion (3933 of 59895)
******************** TEST 'LLVM-Unit :: Support/./SupportTests/HostTest.getMacOSHostVersion' FAILED ********************
Note: Google Test filter = HostTest.getMacOSHostVersion
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from HostTest
[ RUN      ] HostTest.getMacOSHostVersion
/Users/jjb/sat/sledge/llvm-project/llvm/unittests/Support/Host.cpp:352: Failure
      Expected: std::tie(SystemMajor, SystemMinor)
      Which is: (@0x7ffeed1e7514 11, @0x7ffeed1e7510 2)
To be equal to: std::tie(HostMajor, HostMinor)
      Which is: (@0x7ffeed1e745c 11, @0x7ffeed1e7458 0)
[  FAILED  ] HostTest.getMacOSHostVersion (74 ms)
[----------] 1 test from HostTest (74 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (74 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] HostTest.getMacOSHostVersion

 1 FAILED TEST

********************
FAIL: LLVM :: tools/lto/hide-linkonce-odr.ll (59665 of 59895)
******************** TEST 'LLVM :: tools/lto/hide-linkonce-odr.ll' FAILED ********************
Script:
--
: 'RUN: at line 1';   /Users/jjb/sat/sledge/.llvm_build/sledge/bin/llvm-as /Users/jjb/sat/sledge/llvm-project/llvm/test/tools/lto/hide-linkonce-odr.ll -o /Users/jjb/sat/sledge/.llvm_build/sledge/test/tools/lto/Output/hide-linkonce-odr.ll.tmp.o
: 'RUN: at line 2';   /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld -lto_library /Users/jjb/sat/sledge/.llvm_build/sledge/test/../lib/libLTO.dylib -dylib -arch x86_64 -macosx_version_min 10.10.0 -lSystem -o /Users/jjb/sat/sledge/.llvm_build/sledge/test/tools/lto/Output/hide-linkonce-odr.ll.tmp.dylib /Users/jjb/sat/sledge/.llvm_build/sledge/test/tools/lto/Output/hide-linkonce-odr.ll.tmp.o -save-temps  -undefined dynamic_lookup -exported_symbol _c -exported_symbol _b  -exported_symbol _GlobLinkonce
: 'RUN: at line 4';   /Users/jjb/sat/sledge/.llvm_build/sledge/bin/llvm-dis /Users/jjb/sat/sledge/.llvm_build/sledge/test/tools/lto/Output/hide-linkonce-odr.ll.tmp.dylib.lto.opt.bc -o - | /Users/jjb/sat/sledge/.llvm_build/sledge/bin/FileCheck --check-prefix=IR /Users/jjb/sat/sledge/llvm-project/llvm/test/tools/lto/hide-linkonce-odr.ll
: 'RUN: at line 10';   /Users/jjb/sat/sledge/.llvm_build/sledge/bin/llvm-nm /Users/jjb/sat/sledge/.llvm_build/sledge/test/tools/lto/Output/hide-linkonce-odr.ll.tmp.dylib | /Users/jjb/sat/sledge/.llvm_build/sledge/bin/FileCheck --check-prefix=NM /Users/jjb/sat/sledge/llvm-project/llvm/test/tools/lto/hide-linkonce-odr.ll
--
Exit Code: 1

Command Output (stderr):
--
ld: library not found for -lSystem

--

********************
********************
Failed Tests (2):
  LLVM-Unit :: Support/./SupportTests/HostTest.getMacOSHostVersion
  LLVM :: tools/lto/hide-linkonce-odr.ll


Testing Time: 657.96s
  Unsupported      : 17244
  Passed           : 42565
  Expectedly Failed:    84
  Failed           :     2
FAILED: CMakeFiles/check-all

[jberdine]

add X86_amx type and rebase

[jberdine]

ninja check-llvm-bindings-ocaml passes (when rebased on top of D98593)

[jberdine]

appease clang-format

llvm/bindings/ocaml/llvm/llvm.ml

module TypeKind = struct
   | Function
   | Struct
   | Array
   | Pointer
   | Vector
   | Metadata
   | X86_mmx
   | Token
+  | ScalableVector
+  | BFloat
+  | X86_amx
 end
 
 module Linkage = struct
   type t =
   | External
   | Available_externally
   | Link_once
   | Link_once_odr
module Opcode  = struct
   | AddrSpaceCast
   | CleanupRet
   | CatchRet
   | CatchPad
   | CleanupPad
   | CatchSwitch
   | FNeg
   | CallBr
+  | Freeze
 end
 
 module LandingPadClauseTy = struct
   type t =
   | Catch
   | Filter
 end
 
module AtomicRMWBinOp = struct
   | And
   | Nand
   | Or
   | Xor
   | Max
   | Min
   | UMax
   | UMin
+  | FAdd
+  | FSub
 end
 
 module ValueKind = struct
   type t =
   | NullValue
   | Argument
   | BasicBlock
   | InlineAsm

llvm/bindings/ocaml/llvm/llvm.mli

module TypeKind : sig
   | Function
   | Struct
   | Array
   | Pointer
   | Vector
   | Metadata
   | X86_mmx
   | Token
+  | ScalableVector
+  | BFloat
+  | X86_amx
 end
 
 (** The linkage of a global value, accessed with {!linkage} and
     {!set_linkage}. See [llvm::GlobalValue::LinkageTypes]. *)
 module Linkage : sig
   type t =
     External
   | Available_externally
module Opcode : sig
   | AddrSpaceCast
   | CleanupRet
   | CatchRet
   | CatchPad
   | CleanupPad
   | CatchSwitch
   | FNeg
   | CallBr
+  | Freeze
 end
 
 (** The type of a clause of a [landingpad] instruction.
     See [llvm::LandingPadInst::ClauseType]. *)
 module LandingPadClauseTy : sig
   type t =
   | Catch
   | Filter
module AtomicRMWBinOp : sig
   | And
   | Nand
   | Or
   | Xor
   | Max
   | Min
   | UMax
   | UMin
+  | FAdd
+  | FSub
 end
 
 (** The kind of an [llvalue], the result of [classify_value v].
     See the various [LLVMIsA*] functions. *)
 module ValueKind : sig
   type t =
   | NullValue
   | Argument

llvm/bindings/ocaml/llvm/llvm_ocaml.c

 \*===----------------------------------------------------------------------===*/
 
 #include <assert.h>
 #include <stdlib.h>
 #include <string.h>
 #include "llvm-c/Core.h"
 #include "llvm-c/Support.h"
 #include "llvm/Config/llvm-config.h"
 #include "caml/alloc.h"
 #include "caml/custom.h"
 #include "caml/memory.h"
 #include "caml/fail.h"
 #include "caml/callback.h"
 
 value llvm_string_of_message(char* Message) {
   value String = caml_copy_string(Message);
   LLVMDisposeMessage(Message);
DEFINE_ITERATORS(instr, Instruction, LLVMBasicBlockRef, LLVMValueRef,
                  LLVMGetInstructionParent)
 
 /* llvalue -> Opcode.t */
 CAMLprim value llvm_instr_get_opcode(LLVMValueRef Inst) {
   LLVMOpcode o;
   if (!LLVMIsAInstruction(Inst))
       failwith("Not an instruction");
   o = LLVMGetInstructionOpcode(Inst);
-  assert (o <= LLVMCallBr);
+  assert (o <= LLVMFreeze);
   return Val_int(o);
 }
 
 /* llvalue -> ICmp.t option */
 CAMLprim value llvm_instr_icmp_predicate(LLVMValueRef Val) {
   CAMLparam0();
   int x = LLVMGetICmpPredicate(Val);
   if (x) {