This is an archive of the discontinued LLVM Phabricator instance.

Differential D9835

clang-format: Add space in function pointers with SpaceBeforeParens=Always
ClosedPublic

Authored by wanders on May 18 2015, 1:50 PM.

Details

Reviewers
djasper
rsmith
Commits
rGb09075a24068: clang-format: Add space in function pointers with SpaceBeforeParens=Always
rC237704: clang-format: Add space in function pointers with SpaceBeforeParens=Always
rL237704: clang-format: Add space in function pointers with SpaceBeforeParens=Always

Diff Detail

Event Timeline

wanders updated this revision to Diff 26012.May 18 2015, 1:50 PM
wanders retitled this revision from to clang-format: Add space in function pointers with SpaceBeforeParens=Always.
wanders updated this object.
wanders edited the test plan for this revision. (Show Details)
wanders added reviewers: rsmith, djasper.
wanders added a subscriber: Unknown Object (MLST).
Herald added a subscriber: klimek. · View Herald TranscriptMay 18 2015, 1:50 PM
djasper accepted this revision.May 19 2015, 1:34 AM
djasper edited edge metadata.

Looks good. Do you have commit access?

This revision is now accepted and ready to land.May 19 2015, 1:34 AM
wanders added a comment.May 19 2015, 2:04 AM
In D9835#174870, @djasper wrote:

Looks good. Do you have commit access?

Thanks. Yes.

Closed by commit rL237704: clang-format: Add space in function pointers with SpaceBeforeParens=Always (authored by andersg). · Explain WhyMay 19 2015, 9:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Format/
2 lines
unittests/
Format/
2 lines

Diff 26012

lib/Format/TokenAnnotator.cpp

Context not available.
tok::kw_new, tok::kw_delete) && tok::kw_new, tok::kw_delete) &&
(!Left.Previous || Left.Previous->isNot(tok::period))))) || (!Left.Previous || Left.Previous->isNot(tok::period))))) ||
(Style.SpaceBeforeParens == FormatStyle::SBPO_Always && (Style.SpaceBeforeParens == FormatStyle::SBPO_Always &&
(Left.is(tok::identifier) || Left.isFunctionLikeKeyword()) && (Left.is(tok::identifier) || Left.isFunctionLikeKeyword() || Left.is(tok::r_paren)) &&
Line.Type != LT_PreprocessorDirective); Line.Type != LT_PreprocessorDirective);
} }
if (Left.is(tok::at) && Right.Tok.getObjCKeywordID() != tok::objc_not_keyword) if (Left.is(tok::at) && Right.Tok.getObjCKeywordID() != tok::objc_not_keyword)
Context not available.

unittests/Format/FormatTest.cpp

Context not available.
verifyFormat("size_t x = alignof(MyType);", NoSpace); verifyFormat("size_t x = alignof(MyType);", NoSpace);
verifyFormat("static_assert(sizeof(char) == 1, \"Impossible!\");", NoSpace); verifyFormat("static_assert(sizeof(char) == 1, \"Impossible!\");", NoSpace);
verifyFormat("int f() throw(Deprecated);", NoSpace); verifyFormat("int f() throw(Deprecated);", NoSpace);
verifyFormat("typedef void (*cb)(int);", NoSpace);
FormatStyle Space = getLLVMStyle(); FormatStyle Space = getLLVMStyle();
Space.SpaceBeforeParens = FormatStyle::SBPO_Always; Space.SpaceBeforeParens = FormatStyle::SBPO_Always;
Context not available.
verifyFormat("size_t x = alignof (MyType);", Space); verifyFormat("size_t x = alignof (MyType);", Space);
verifyFormat("static_assert (sizeof (char) == 1, \"Impossible!\");", Space); verifyFormat("static_assert (sizeof (char) == 1, \"Impossible!\");", Space);
verifyFormat("int f () throw (Deprecated);", Space); verifyFormat("int f () throw (Deprecated);", Space);
verifyFormat("typedef void (*cb) (int);", Space);
} }
TEST_F(FormatTest, ConfigurableSpacesInParentheses) { TEST_F(FormatTest, ConfigurableSpacesInParentheses) {
Context not available.