Page MenuHomePhabricator

[dfsan] Tracking origins at phi nodes
ClosedPublic

Authored by stephan.yichao.zhao on Mar 9 2021, 9:14 AM.

Diff Detail

Event Timeline

stephan.yichao.zhao requested review of this revision.Mar 9 2021, 9:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2021, 9:14 AM

Can we add an end-to-end test as well?

llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
1572–1580

Nit: range for loop is cleaner if we don't need to advance iterators ourselves.

2713

This is unrelated and shouldn't be in this diff...

3141–3142

Nit: range for loop is cleaner

stephan.yichao.zhao marked 3 inline comments as done.

used range loops

llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
2713

rebased after D98192.

Can we add an end-to-end test to compiler-rt?

added a compiler-rt test

Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2021, 3:14 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
This revision is now accepted and ready to land.Mar 9 2021, 3:32 PM
This revision was landed with ongoing or failed builds.Mar 10 2021, 9:03 AM
This revision was automatically updated to reflect the committed changes.