This is an archive of the discontinued LLVM Phabricator instance.

mapfile(abandoned)
AbandonedPublic

Authored by int3 on Mar 9 2021, 5:06 AM.

Details

Reviewers
thakis
woshiccm
Group Reviewers
Restricted Project

Diff Detail

Event Timeline

woshiccm created this revision.Mar 9 2021, 5:06 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
woshiccm requested review of this revision.Mar 9 2021, 5:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2021, 5:06 AM
woshiccm removed reviewers: int3, Restricted Project.Mar 9 2021, 5:08 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
int3 added a comment.Mar 9 2021, 6:19 AM

Hi Roy :) glad to have you on board. Did you forget to add some files to this diff?

Hi Roy :) glad to have you on board. Did you forget to add some files to this diff?

I have not submitted a patch to LLVM before, this is a test. The complete patch is this https://reviews.llvm.org/D98323

thakis requested changes to this revision.Mar 10 2021, 6:08 AM
thakis added a subscriber: thakis.

Since this is now at https://reviews.llvm.org/D98323 , could you mark this revision here as abandoned? Marking it as "request changes" (the most I can do) so it's off my dashboard :)

This revision now requires changes to proceed.Mar 10 2021, 6:08 AM
woshiccm retitled this revision from mapfile to mapfile(abandoned).Mar 11 2021, 12:49 AM
int3 added a comment.Mar 11 2021, 9:19 AM

If you scroll to the bottom, there's a box saying "Add Action..." -- that will have an option to properly abandon the diff so it won't show up on other people's review queues

int3 commandeered this revision.Mar 18 2021, 8:09 AM
int3 abandoned this revision.
int3 edited reviewers, added: woshiccm; removed: int3.