[lldb] Add missing debugserver/lldb-server dependencies to check-lldb

[teemperor]

Summary

D96202 removes the test dependencies on debugserver/lldb-server which is causing a bunch of
tests to fail on a clean build.

This patch re-adds those dependencies. I decided to not add the dependencies in the test/API
folder as we actually need those dependencies in all kinds of tests (we have shell, API and a few unit
tests such as the LLDBServerTests that depend on these binaries).

[JDevlieghere]

LGTM

lldb/test/CMakeLists.txt

47

I was worried about the situation where we tell LLDB to test with the system debugserver, but unless I misremember the target won't be there when that's the case, so this is perfect.

[labath]

lldb/test/CMakeLists.txt

47

test/API/CMakeLists.txt will create a "debugserver" target in that case (in order to copy it into the build dir). However, I think this is exactly what we want to happen here.

49–51

It seems this is already present on line 59.

[JDevlieghere]

lldb/test/CMakeLists.txt

47

So I did misremember, but the result is the same. Nice :-)

[teemperor]

lldb/test/CMakeLists.txt

49–51

Good point, I'll just add the dependency there then.

lldb/test/CMakeLists.txt

foreach(dependency ${ARGN})
     add_dependencies(lldb-test-deps ${dependency})
   endforeach()
 endfunction(add_lldb_test_dependency)
 
 # lldb itself and lldb-test is an hard dependency for the testsuites.
 add_lldb_test_dependency(lldb)
 add_lldb_test_dependency(lldb-test)
 
 # On Darwin, darwin-debug is an hard dependency for the testsuites.
 if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
   add_lldb_test_dependency(darwin-debug)
 endif()
 
+if(TARGET debugserver)
+  add_lldb_test_dependency(debugserver)
+endif()
 if(TARGET lldb-server)
   add_lldb_test_dependency(lldb-server)
 endif()
 
 if(TARGET lldb-vscode)
   add_lldb_test_dependency(lldb-vscode)
 endif()