Page MenuHomePhabricator

[lldb] Fix error message in IRInterpreter
ClosedPublic

Authored by werat on Mar 8 2021, 4:44 AM.

Details

Summary

memory_read_error -> memory_write_error

Diff Detail

Event Timeline

werat requested review of this revision.Mar 8 2021, 4:44 AM
werat created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2021, 4:44 AM
teemperor accepted this revision.Mar 8 2021, 4:49 AM

LGTM.

I think the Read/Write methods should return a Status instead of some out parameter, but that seems like a NFC follow-up refactoring (I can take care of that).

This revision is now accepted and ready to land.Mar 8 2021, 4:49 AM

I would be curious how you found that bug? I believe a lot of these errors are kinda impossible to reach in a normal test setup (I remember I tried writing some tests for this but can't remember finding a good way to get into all the different error branches in IRInterpreter).

werat added a comment.Mar 8 2021, 5:07 AM

I was looking into the issue with SBValue::Persist (https://discord.com/channels/636084430946959380/636732809708306432/817370459284832297) and the logs and errors eventually led me here to IRInterpreter. And the incorrect error message I noticed just by accident :)

This revision was landed with ongoing or failed builds.Mar 8 2021, 7:47 AM
This revision was automatically updated to reflect the committed changes.