[libcxx] [test] Fix temp_directory_path for windows

[mstorsjo]

Summary

Check a different set of env vars, don't check the exact value
of the fallback path. (GetTempPath falls back to returning c:\windows
if nothing better is available in env vars.)

[curdeius]

LGTM if you clarify the comment.

libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.temp_dir_path/temp_directory_path.pass.cpp

126

Nit: capital in Windows.

126

I'd rather go for a precise piece of information in the comment, as you wrote in the revision summary, the fallback is the Windows folder (https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-gettemppatha#remarks).

[mstorsjo]

Clarified the comment as requested

[curdeius]

libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.temp_dir_path/temp_directory_path.pass.cpp

126

Nit: the Windows folder is not necessarily C:\Windows. Don't bother to change it before landing.

[mstorsjo]

libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.temp_dir_path/temp_directory_path.pass.cpp

126

Oh, right, that's true, thanks!

[mstorsjo]

Ping for second approval

[mstorsjo]

Ping for second approval

[• Quuxplusone]

libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.temp_dir_path/temp_directory_path.pass.cpp

67

Is there any significance to starting with dir2 on Windows versus dir1 on POSIX?

Also, this is scope creep, but do you maybe want to (in a separate PR) make a test case to show that the setting of env var TMPDIR is correctly ignored on Windows?

[mstorsjo]

libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.temp_dir_path/temp_directory_path.pass.cpp

67

Not really, just copy/paste laziness, I can change it to start with dir1 there too.

Hmm, I guess I could try to extend the test to check for ignored variables too, as a later patch.

[• Quuxplusone]

LGTM after changing to dir1 etc.; please double-check that the tests still pass after that change, then ship it!

libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.temp_dir_path/temp_directory_path.pass.cpp

TEST_CASE(basic_tests)
     const path dir_perms = env.create_dir("bad_perms_dir");
     const path nested_dir = env.create_dir("bad_perms_dir/nested");
     permissions(dir_perms, perms::none);
     LIBCPP_ONLY(const std::errc expect_errc = std::errc::not_a_directory);
     struct TestCase {
       std::string name;
       path p;
     } cases[] = {
+#ifdef _WIN32
+        {"TMP", env.create_dir("dir2")},
+        {"TEMP", env.create_dir("dir3")},
+        {"USERPROFILE", env.create_dir("dir4")}
+#else
         {"TMPDIR", env.create_dir("dir1")},
         {"TMP", env.create_dir("dir2")},
         {"TEMP", env.create_dir("dir3")},
         {"TEMPDIR", env.create_dir("dir4")}
+#endif
     };
     for (auto& TC : cases) {
         PutEnv(TC.name, TC.p);
     }
     for (auto& TC : cases) {
         std::error_code ec = GetTestEC();
         path ret = temp_directory_path(ec);
         TEST_CHECK(!ec);
#endif
         // Finally erase this env variable
         UnsetEnv(TC.name);
     }
     // No env variables are defined
     {
         std::error_code ec = GetTestEC();
         path ret = temp_directory_path(ec);
         TEST_CHECK(!ec);
+#ifndef _WIN32
+        // On windows, a different fallback is used.
         TEST_CHECK(ret == "/tmp");
+#endif
         TEST_CHECK(is_directory(ret));
     }
 }
 
 TEST_SUITE_END()