[libcxx] [test] Don't test CharFile (/dev/null) on windows

[mstorsjo]

Reupload to retry CI

[• Quuxplusone]

libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.status/status.pass.cpp

116

You might adjust this comment to // file_type::block is tested elsewhere, just so that people don't assume it's related to the #ifndef on the next line.
(And ditto in the other test file, as well.)

[curdeius]

Have you heard of nul special file on Windows?
https://gcc.gnu.org/legacy-ml/gcc-patches/2005-05/msg01793.html
I haven't tested it yet but maybe using it on Win instead of /dev/null might be a good idea?

[mstorsjo]

In D98138#2609952, @curdeius wrote:

Have you heard of nul special file on Windows?
https://gcc.gnu.org/legacy-ml/gcc-patches/2005-05/msg01793.html
I haven't tested it yet but maybe using it on Win instead of /dev/null might be a good idea?

Good point, but neither our implementation nor the MS STL one actually identify files as file_type::character, see https://github.com/microsoft/STL/blob/main/stl/inc/filesystem#L1882 which says:

character, // not used in this implementation; theoretically some special files like CON might qualify, but querying for this is extremely expensive and unlikely to be useful in practice

libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.status/status.pass.cpp

116

Sure, I can do that.

[curdeius]

LGTM. Could you put a similar comment (but concerning only Windows of course) near file_type::character declaration as well?

[mstorsjo]

In D98138#2610071, @curdeius wrote:

LGTM. Could you put a similar comment (but concerning only Windows of course) near file_type::character declaration as well?

In the header? Sure, I can make a separate patch for that.

libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.status/status.pass.cpp

TEST_CASE(status_file_types_test)
     struct TestCase {
       path p;
       file_type expect_type;
     } cases[] = {
         {static_env.File, file_type::regular},
         {static_env.SymlinkToFile, file_type::regular},
         {static_env.Dir, file_type::directory},
         {static_env.SymlinkToDir, file_type::directory},
         // Block files tested elsewhere
+#ifndef _WIN32
         {static_env.CharFile, file_type::character},
+#endif
 #if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(_WIN32) // No support for domain sockets
         {env.create_socket("socket"), file_type::socket},
 #endif
 #ifndef _WIN32
         {env.create_fifo("fifo"), file_type::fifo}
 #endif
     };
     for (const auto& TC : cases) {

libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.symlink_status/symlink_status.pass.cpp

struct TestCase {
       file_type expect_type;
     } cases[] = {
         {static_env.BadSymlink, file_type::symlink},
         {static_env.File, file_type::regular},
         {static_env.SymlinkToFile, file_type::symlink},
         {static_env.Dir, file_type::directory},
         {static_env.SymlinkToDir, file_type::symlink},
         // Block files tested elsewhere
+#ifndef _WIN32
         {static_env.CharFile, file_type::character},
+#endif
 #if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(_WIN32) // No support for domain sockets
         {env.create_socket("socket"), file_type::socket},
 #endif
 #ifndef _WIN32
         {env.create_fifo("fifo"), file_type::fifo}
 #endif
     };
     for (const auto& TC : cases) {