Details
Details
- Reviewers
curdeius • Quuxplusone - Group Reviewers
Restricted Project - Commits
- rGab67fd39fc14: [libcxx] [test] Fix path.modifiers remove_filename and replace_filename for…
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| libcxx/test/std/input.output/filesystems/class.path/path.member/path.modifiers/replace_filename.pass.cpp | ||
|---|---|---|
| 49–50 | These two ifdefs can be merged; I'll do that locally before the next update or before pushing. | |
Comment Actions
LGTM. Don't forget to merge the ifdefs when landing.
| libcxx/test/std/input.output/filesystems/class.path/path.member/path.modifiers/replace_filename.pass.cpp | ||
|---|---|---|
| 15 | Could you please update this synopsis extract to path& replace_filename( const path& replacement ); when you're here? | |
| libcxx/test/std/input.output/filesystems/class.path/path.member/path.modifiers/replace_filename.pass.cpp | ||
|---|---|---|
| 15 | Sure, will do. | |
Could you please update this synopsis extract to path& replace_filename( const path& replacement ); when you're here?