This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Fix path.modifiers remove_filename and replace_filename for windows
ClosedPublic

Authored by mstorsjo on Mar 5 2021, 11:55 PM.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Mar 5 2021, 11:55 PM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2021, 11:55 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
mstorsjo added inline comments.Mar 6 2021, 10:03 AM
libcxx/test/std/input.output/filesystems/class.path/path.member/path.modifiers/replace_filename.pass.cpp
49–50

These two ifdefs can be merged; I'll do that locally before the next update or before pushing.

curdeius accepted this revision as: curdeius.Mar 6 2021, 2:08 PM
curdeius added a subscriber: curdeius.

LGTM. Don't forget to merge the ifdefs when landing.

libcxx/test/std/input.output/filesystems/class.path/path.member/path.modifiers/replace_filename.pass.cpp
15

Could you please update this synopsis extract to path& replace_filename( const path& replacement ); when you're here?

This revision is now accepted and ready to land.Mar 6 2021, 3:12 PM
mstorsjo added inline comments.Mar 7 2021, 12:42 AM
libcxx/test/std/input.output/filesystems/class.path/path.member/path.modifiers/replace_filename.pass.cpp
15

Sure, will do.