This is an archive of the discontinued LLVM Phabricator instance.

Differential D98098

[NFC][LoopUnroll] Add `-unroll-runtime-other-exit-predictable=false` in `runtime-multiexit-heuristic.ll`
ClosedPublic

Authored by Whitney on Mar 5 2021, 7:37 PM.

Details

Reviewers
Meinersbur
bmahjour
Commits
rG0d8f102809b2: [NFC][LoopUnroll] Add `-unroll-runtime-other-exit-predictable=false` in
Summary

Added -unroll-runtime-other-exit-predictable=false in runtime-multiexit-heuristic.ll to make it more robust.
runtime-multiexit-heuristic.ll intention is to test -unroll-runtime-multi-exit=false, so the default value of -unroll-runtime-other-exit-predictable should not impact the result.

Diff Detail

Unit TestsFailed

TimeTest
1,860 msx64 debian > libarcher.races::lock-unrelated.c

Event Timeline

Whitney created this revision.Mar 5 2021, 7:37 PM
Herald added a subscriber: zzheng. · View Herald TranscriptMar 5 2021, 7:37 PM
Whitney requested review of this revision.Mar 5 2021, 7:37 PM
Herald added a subscriber: llvm-commits. · View Herald TranscriptMar 5 2021, 7:37 PM
Harbormaster completed remote builds in B92449: Diff 328722.Mar 6 2021, 3:07 PM
Meinersbur accepted this revision.Mar 7 2021, 12:30 PM

LGTM

This revision is now accepted and ready to land.Mar 7 2021, 12:30 PM
This revision was landed with ongoing or failed builds.Mar 7 2021, 3:53 PM
Closed by commit rG0d8f102809b2: [NFC][LoopUnroll] Add `-unroll-runtime-other-exit-predictable=false` in (authored by Whitney). · Explain Why
This revision was automatically updated to reflect the committed changes.
Whitney added a commit: rG0d8f102809b2: [NFC][LoopUnroll] Add `-unroll-runtime-other-exit-predictable=false` in.

Revision Contents

PathSize
llvm/
test/
Transforms/
LoopUnroll/
4 lines

Diff 328722

llvm/test/Transforms/LoopUnroll/runtime-multiexit-heuristic.ll

; RUN: opt < %s -loop-unroll -unroll-runtime=true -verify-dom-info -verify-loop-info -instcombine -S | FileCheck %s ; RUN: opt < %s -unroll-runtime-other-exit-predictable=false -loop-unroll -unroll-runtime=true -verify-dom-info -verify-loop-info -instcombine -S | FileCheck %s
; RUN: opt < %s -loop-unroll -unroll-runtime=true -verify-dom-info -unroll-runtime-multi-exit=false -verify-loop-info -S | FileCheck %s -check-prefix=NOUNROLL ; RUN: opt < %s -unroll-runtime-other-exit-predictable=false -loop-unroll -unroll-runtime=true -verify-dom-info -unroll-runtime-multi-exit=false -verify-loop-info -S | FileCheck %s -check-prefix=NOUNROLL
; this tests when unrolling multiple exit loop occurs by default (i.e. without specifying -unroll-runtime-multi-exit) ; this tests when unrolling multiple exit loop occurs by default (i.e. without specifying -unroll-runtime-multi-exit)
; the second exit block is a deopt block. The loop has one exiting block other than the latch. ; the second exit block is a deopt block. The loop has one exiting block other than the latch.
define i32 @test1(i32* nocapture %a, i64 %n) { define i32 @test1(i32* nocapture %a, i64 %n) {
; CHECK-LABEL: test1( ; CHECK-LABEL: test1(
; CHECK-LABEL: header.epil: ; CHECK-LABEL: header.epil:
; CHECK-NEXT: %indvars.iv.epil = phi i64 [ %indvars.iv.next.epil, %latch.epil ], [ %indvars.iv.unr, %header.epil.preheader ] ; CHECK-NEXT: %indvars.iv.epil = phi i64 [ %indvars.iv.next.epil, %latch.epil ], [ %indvars.iv.unr, %header.epil.preheader ]
▲ Show 20 Lines • Show All 84 Lines • Show Last 20 Lines