This is an archive of the discontinued LLVM Phabricator instance.

libcxx: Enhance lit test command in verbose mode.
ClosedPublic

Authored by logan on May 16 2015, 5:24 AM.

Download Raw Diff

Details

Reviewers

rengolin
jroelofs
EricWF

Summary

Print both the compiler command and linker command so that it will be
easier for developers to reproduce the failed test cases.

Diff Detail

Event Timeline

logan updated this revision to Diff 25916.May 16 2015, 5:24 AM

logan retitled this revision from to libcxx: Enhance lit test command in verbose mode..

logan updated this object.

logan edited the test plan for this revision. (Show Details)

logan added reviewers: rengolin, EricWF.

logan added a subscriber: Unknown Object (MLST).

LGTM

This revision is now accepted and ready to land.May 16 2015, 6:53 AM

LGTM too

Thanks for reviewing. Committed as rL237530.

Revision Contents

Path

Size

test/

libcxx/

compiler.py

13 lines

Diff 25916

test/libcxx/compiler.py

Show First 20 Lines • Show All 101 Lines • ▼ Show 20 Lines	def compileLinkTwoSteps(self, source_file, out=None, object_file=None,
raise TypeError('This function only accepts a single input file')		raise TypeError('This function only accepts a single input file')
if object_file is None:		if object_file is None:
# Create, use and delete a temporary object file if none is given.		# Create, use and delete a temporary object file if none is given.
with_fn = lambda: libcxx.util.guardedTempFilename(suffix='.o')		with_fn = lambda: libcxx.util.guardedTempFilename(suffix='.o')
else:		else:
# Otherwise wrap the filename in a context manager function.		# Otherwise wrap the filename in a context manager function.
with_fn = lambda: libcxx.util.nullContext(object_file)		with_fn = lambda: libcxx.util.nullContext(object_file)
with with_fn() as object_file:		with with_fn() as object_file:
cmd, output, err, rc = self.compile(source_file, object_file,		cc_cmd, cc_stdout, cc_stderr, rc = self.compile(
flags=flags, env=env, cwd=cwd)		source_file, object_file, flags=flags, env=env, cwd=cwd)
if rc != 0:		if rc != 0:
return cmd, output, err, rc		return cc_cmd, cc_stdout, cc_stderr, rc
return self.link(object_file, out=out, flags=flags, env=env,
cwd=cwd)		link_cmd, link_stdout, link_stderr, rc = self.link(
		object_file, out=out, flags=flags, env=env, cwd=cwd)
		return (cc_cmd + ['&&'] + link_cmd, cc_stdout + link_stdout,
		cc_stderr + link_stderr, rc)

def dumpMacros(self, source_files=None, flags=[], env=None, cwd=None):		def dumpMacros(self, source_files=None, flags=[], env=None, cwd=None):
if source_files is None:		if source_files is None:
source_files = os.devnull		source_files = os.devnull
flags = ['-dM'] + flags		flags = ['-dM'] + flags
cmd, out, err, rc = self.preprocess(source_files, flags=flags, env=env,		cmd, out, err, rc = self.preprocess(source_files, flags=flags, env=env,
cwd=cwd)		cwd=cwd)
if rc != 0:		if rc != 0:
Show All 13 Lines