Page MenuHomePhabricator

[libcxx] Remove an unused overload in filesystem_common.h. NFC.
AbandonedPublic

Authored by mstorsjo on Mar 5 2021, 11:54 AM.

Details

Reviewers
curdeius
Quuxplusone
Group Reviewers
Restricted Project
Summary

D96986 refactors this bit entirely though.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Mar 5 2021, 11:54 AM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2021, 11:54 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
curdeius accepted this revision as: curdeius.Mar 5 2021, 12:18 PM
curdeius added a subscriber: curdeius.

LGTM.

Quuxplusone accepted this revision.Mar 5 2021, 12:42 PM
Quuxplusone added a subscriber: Quuxplusone.

Sure, assuming it passes tests.
However, eyeballing the uses of this thing, I got to directory_iterator.cpp, which does

err.report(m_ec, "at root \"%s\"", root);

That produces garbage on Windows, right? because root is a path and the way we unwrap(path const&) is to turn it into a wchar_t*, not a char*?

This revision is now accepted and ready to land.Mar 5 2021, 12:42 PM

Sure, assuming it passes tests.
However, eyeballing the uses of this thing, I got to directory_iterator.cpp, which does

err.report(m_ec, "at root \"%s\"", root);

That produces garbage on Windows, right? because root is a path and the way we unwrap(path const&) is to turn it into a wchar_t*, not a char*?

Oh, you're right - I had missed that one (I have the same issue fixed in a couple other cases in operations.cpp). Thanks! I tried applying D96986 and then I do get format warnings that point out exactly this.

I'll get a fix posted for that issue.

This is superseded by D98097, right?

mstorsjo abandoned this revision.Mar 13 2021, 12:05 AM

This is superseded by D98097, right?

Yes - I guess I can close this one right away.