[lldb/API] Add CommandInterpreter::{Get,Set}PrintErrors to SBAPI (NFC)

[mib]

Summary

This patch exposes the getter and setter methods for the command
interpreter print_errors run option.

rdar://74816984

Signed-off-by: Med Ismail Bennani <[e-mail]>

[JDevlieghere]

Test?

[mib]

Add test.

[JDevlieghere]

LGTM with the \n.

lldb/test/API/python_api/interpreter/TestRunCommandInterpreterAPI.py

113

No newline at end of file

lldb/bindings/interface/SBCommandInterpreterRunOptions.i

 
 A default SBCommandInterpreterRunOptions object has:
 
 * StopOnContinue: false
 * StopOnError:    false
 * StopOnCrash:    false
 * EchoCommands:   true
 * PrintResults:   true
+* PrintErrors:    true
 * AddToHistory:   true
 
 ") SBCommandInterpreterRunOptions;
 class SBCommandInterpreterRunOptions
 {
 friend class SBDebugger;
 public:
     SBCommandInterpreterRunOptions();
public:
 
     bool
     GetPrintResults () const;
 
     void
     SetPrintResults (bool);
 
     bool
+    GetPrintErrors () const;
+
+    void
+    SetPrintErrors (bool);
+
+    bool
     GetAddToHistory () const;
 
     void
     SetAddToHistory (bool);
 private:
     lldb_private::CommandInterpreterRunOptions *
     get () const;
 
     lldb_private::CommandInterpreterRunOptions &
     ref () const;
 
     // This is set in the constructor and will always be valid.
     mutable std::unique_ptr<lldb_private::CommandInterpreterRunOptions> m_opaque_up;
 };
 
 } // namespace lldb

lldb/include/lldb/API/SBCommandInterpreterRunOptions.h

public:
   bool GetEchoCommentCommands() const;
 
   void SetEchoCommentCommands(bool echo);
 
   bool GetPrintResults() const;
 
   void SetPrintResults(bool);
 
+  bool GetPrintErrors() const;
+
+  void SetPrintErrors(bool);
+
   bool GetAddToHistory() const;
 
   void SetAddToHistory(bool);
 
   bool GetAutoHandleEvents() const;
 
   void SetAutoHandleEvents(bool);
 

lldb/source/API/SBCommandInterpreterRunOptions.cpp

 
 void SBCommandInterpreterRunOptions::SetPrintResults(bool print_results) {
   LLDB_RECORD_METHOD(void, SBCommandInterpreterRunOptions, SetPrintResults,
                      (bool), print_results);
 
   m_opaque_up->SetPrintResults(print_results);
 }
 
+bool SBCommandInterpreterRunOptions::GetPrintErrors() const {
+  LLDB_RECORD_METHOD_CONST_NO_ARGS(bool, SBCommandInterpreterRunOptions,
+                                   GetPrintErrors);
+
+  return m_opaque_up->GetPrintErrors();
+}
+
+void SBCommandInterpreterRunOptions::SetPrintErrors(bool print_errors) {
+  LLDB_RECORD_METHOD(void, SBCommandInterpreterRunOptions, SetPrintErrors,
+                     (bool), print_errors);
+
+  m_opaque_up->SetPrintErrors(print_errors);
+}
+
 bool SBCommandInterpreterRunOptions::GetAddToHistory() const {
   LLDB_RECORD_METHOD_CONST_NO_ARGS(bool, SBCommandInterpreterRunOptions,
                                    GetAddToHistory);
 
   return m_opaque_up->GetAddToHistory();
 }
 
 void SBCommandInterpreterRunOptions::SetAddToHistory(bool add_to_history) {
LLDB_REGISTER_METHOD_CONST(bool, SBCommandInterpreterRunOptions,
                              GetEchoCommentCommands, ());
   LLDB_REGISTER_METHOD(void, SBCommandInterpreterRunOptions,
                        SetEchoCommentCommands, (bool));
   LLDB_REGISTER_METHOD_CONST(bool, SBCommandInterpreterRunOptions,
                              GetPrintResults, ());
   LLDB_REGISTER_METHOD(void, SBCommandInterpreterRunOptions, SetPrintResults,
                        (bool));
   LLDB_REGISTER_METHOD_CONST(bool, SBCommandInterpreterRunOptions,
+                             GetPrintErrors, ());
+  LLDB_REGISTER_METHOD(void, SBCommandInterpreterRunOptions, SetPrintErrors,
+                       (bool));
+  LLDB_REGISTER_METHOD_CONST(bool, SBCommandInterpreterRunOptions,
                              GetAddToHistory, ());
   LLDB_REGISTER_METHOD(void, SBCommandInterpreterRunOptions, SetAddToHistory,
                        (bool));
   LLDB_REGISTER_METHOD_CONST(bool, SBCommandInterpreterRunOptions,
                              GetAutoHandleEvents, ());
   LLDB_REGISTER_METHOD(void, SBCommandInterpreterRunOptions,
                        SetAutoHandleEvents, (bool));
   LLDB_REGISTER_METHOD_CONST(bool, SBCommandInterpreterRunOptions,

lldb/test/API/python_api/interpreter/TestRunCommandInterpreterAPI.py

def test_run_session_with_error_and_quit(self):
 
         n_errors, quit_requested, has_crashed = self.dbg.RunCommandInterpreter(
                 True, False, lldb.SBCommandInterpreterRunOptions(), 0, False,
                 False)
 
         self.assertGreater(n_errors, 0)
         self.assertTrue(quit_requested)
         self.assertFalse(has_crashed)
+
+class SBCommandInterpreterRunOptionsCase(TestBase):
+
+    NO_DEBUG_INFO_TESTCASE = True
+    mydir = TestBase.compute_mydir(__file__)
+
+    def test_command_interpreter_run_options(self):
+        """Test SBCommandInterpreterRunOptions default values, getters & setters """
+
+        opts = lldb.SBCommandInterpreterRunOptions()
+
+        # Check getters with default values
+        self.assertEqual(opts.GetStopOnContinue(), False)
+        self.assertEqual(opts.GetStopOnError(), False)
+        self.assertEqual(opts.GetStopOnCrash(), False)
+        self.assertEqual(opts.GetEchoCommands(), True)
+        self.assertEqual(opts.GetPrintResults(), True)
+        self.assertEqual(opts.GetPrintErrors(), True)
+        self.assertEqual(opts.GetAddToHistory(), True)
+
+        # Invert values
+        opts.SetStopOnContinue(not opts.GetStopOnContinue())
+        opts.SetStopOnError(not opts.GetStopOnError())
+        opts.SetStopOnCrash(not opts.GetStopOnCrash())
+        opts.SetEchoCommands(not opts.GetEchoCommands())
+        opts.SetPrintResults(not opts.GetPrintResults())
+        opts.SetPrintErrors(not opts.GetPrintErrors())
+        opts.SetAddToHistory(not opts.GetAddToHistory())
+
+        # Check the value changed
+        self.assertEqual(opts.GetStopOnContinue(), True)
+        self.assertEqual(opts.GetStopOnError(), True)
+        self.assertEqual(opts.GetStopOnCrash(), True)
+        self.assertEqual(opts.GetEchoCommands(), False)
+        self.assertEqual(opts.GetPrintResults(), False)
+        self.assertEqual(opts.GetPrintErrors(), False)
+        self.assertEqual(opts.GetAddToHistory(), False)