This is an archive of the discontinued LLVM Phabricator instance.

Differential D97933

[asan][test] Don't XFAIL Posix/unpoison-alternate-stack.cpp on Solaris
ClosedPublic

Authored by ro on Mar 4 2021, 4:23 AM.

Details

Reviewers
vitalybuka
Commits
rG579fd0259788: [asan][test] Don't XFAIL Posix/unpoison-alternate-stack.cpp on Solaris
Summary

One ASan test currently XPASSes on Solaris:

AddressSanitizer-i386-sunos :: TestCases/Posix/unpoison-alternate-stack.cpp

It was originally XFAILed in D88501 because longjmp from a signal handled is highly
unportable, warned against in XPG7, and was not supported by Solaris libc at the time.

However, since then support has been added for some cases including the current one,
so the XFAIL can go.

Tested on amd64-pc-solaris2.11 and x86_64-pc-linux-gnu.

However, there's a way more portable alternative, namely using siglongjmp instead
that might also be considered.

Diff Detail

Revision Contents

PathSize
compiler-rt/
test/
asan/
TestCases/
Posix/
2 lines

Diff 328419

compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp

// Tests that __asan_handle_no_return properly unpoisons the signal alternate // Tests that __asan_handle_no_return properly unpoisons the signal alternate
// stack. // stack.
// Don't optimize, otherwise the variables which create redzones might be // Don't optimize, otherwise the variables which create redzones might be
// dropped. // dropped.
// RUN: %clangxx_asan -std=c++20 -fexceptions -O0 %s -o %t -pthread // RUN: %clangxx_asan -std=c++20 -fexceptions -O0 %s -o %t -pthread
// RUN: %run %t // RUN: %run %t
// XFAIL: ios && !iossim // XFAIL: ios && !iossim
// longjmp from signal handler is unportable.
// XFAIL: solaris
#include <algorithm> #include <algorithm>
#include <cassert> #include <cassert>
#include <cerrno> #include <cerrno>
#include <csetjmp> #include <csetjmp>
#include <cstdint> #include <cstdint>
#include <cstdio> #include <cstdio>
#include <cstdlib> #include <cstdlib>
▲ Show 20 Lines • Show All 151 Lines • Show Last 20 Lines