This is an archive of the discontinued LLVM Phabricator instance.

Differential D108030

[asan][test] Un-xfail Posix/unpoison-alternate-stack.cpp on Solaris again
ClosedPublic

Authored by ro on Aug 13 2021, 5:57 AM.

Details

Reviewers
vitalybuka
Commits
rGc35e4dc8dd0b: [asan][test] Un-xfail Posix/unpoison-alternate-stack.cpp on Solaris again
Summary

Posix/unpoison-alternate-stack.cpp currently XPASSes on Solaris. The XFAIL had
already been removed in D97933, but reintroduced by commit f03d29601e0951da2c88f07d4234128e14e87870 which was never posted or justified.

Given the XPASS, this obviously wasn't NFC, so I suggest to remove it again.

Tested on amd64-pc-solaris2.11 and x86_64-pc-linux-gnu.

Diff Detail

Event Timeline

ro created this revision.Aug 13 2021, 5:57 AM
Herald added subscribers: pengfei, fedor.sergeev. · View Herald TranscriptAug 13 2021, 5:57 AM
ro requested review of this revision.Aug 13 2021, 5:57 AM
Herald added a subscriber: Restricted Project. · View Herald TranscriptAug 13 2021, 5:57 AM
Harbormaster completed remote builds in B119431: Diff 366258.Aug 13 2021, 6:29 AM
vitalybuka accepted this revision.Aug 14 2021, 5:32 PM
This revision is now accepted and ready to land.Aug 14 2021, 5:32 PM
This revision was landed with ongoing or failed builds.Aug 15 2021, 12:21 AM
Closed by commit rGc35e4dc8dd0b: [asan][test] Un-xfail Posix/unpoison-alternate-stack.cpp on Solaris again (authored by ro). · Explain Why
This revision was automatically updated to reflect the committed changes.
ro added a commit: rGc35e4dc8dd0b: [asan][test] Un-xfail Posix/unpoison-alternate-stack.cpp on Solaris again.

Revision Contents

PathSize
compiler-rt/
test/
asan/
TestCases/
Posix/
3 lines

Diff 366478

compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp

// Tests that __asan_handle_no_return properly unpoisons the signal alternate // Tests that __asan_handle_no_return properly unpoisons the signal alternate
// stack. // stack.
// Don't optimize, otherwise the variables which create redzones might be // Don't optimize, otherwise the variables which create redzones might be
// dropped. // dropped.
// RUN: %clangxx_asan -std=c++20 -fexceptions -O0 %s -o %t -pthread // RUN: %clangxx_asan -std=c++20 -fexceptions -O0 %s -o %t -pthread
// RUN: %run %t // RUN: %run %t
// longjmp from signal handler is unportable.
// XFAIL: solaris
#include <algorithm> #include <algorithm>
#include <cassert> #include <cassert>
#include <cerrno> #include <cerrno>
#include <csetjmp> #include <csetjmp>
#include <cstdint> #include <cstdint>
#include <cstdio> #include <cstdio>
#include <cstdlib> #include <cstdlib>
#include <cstring> #include <cstring>
▲ Show 20 Lines • Show All 150 Lines • Show Last 20 Lines