Page MenuHomePhabricator

[CMake] Rename check-clang-tools to check-clang-tools-extra
AcceptedPublic

Authored by phosek on Mar 2 2021, 4:33 PM.

Details

Reviewers
smeenai
Summary

Match the top-level project name (that is the name developers would use
in LLVM_ENABLE_PROJECTS) with the name of the target, and provide alias
for backwards compatibility.

Diff Detail

Event Timeline

phosek created this revision.Mar 2 2021, 4:33 PM
phosek requested review of this revision.Mar 2 2021, 4:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2021, 4:33 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
smeenai accepted this revision.Mar 2 2021, 4:35 PM

LGTM.

If you care about eventually getting rid of the old check-clang-tools alias, you'd want to have a mailing list announcement/deprecation notices/etc. (I don't think leaving it around does any harm though.)

Might want to add a release notes entry?

This revision is now accepted and ready to land.Mar 2 2021, 4:35 PM
smeenai added inline comments.Mar 2 2021, 4:36 PM
clang-tools-extra/test/CMakeLists.txt
81

Nit: You need an explicit "'s" now (as in "Clang tools extra's regression tests"), since "extra" doesn't end with an s.

87

Same here.