Just includes patch to add bulk of target, not tests or other prerequisite patches.
Details
Diff Detail
Event Timeline
lib/Target/HSAIL/CMakeLists.txt | ||
---|---|---|
20 | Please leave this out of the first version. Having two code paths in CodeGen in pretty bad, specially when one of them depends on an external library. |
include/llvm/Support/ELF.h | ||
---|---|---|
237 | I don't see these in http://www.sco.com/developers/gabi/latest/ch4.eheader.html. | |
lib/Target/HSAIL/CMakeLists.txt | ||
50 | No commented out code please. | |
lib/Target/HSAIL/HSAIL.h | ||
69 | Empty comments? | |
103 | Don't repeat names in comments. | |
lib/Target/HSAIL/HSAILAlwaysInlinePass.cpp | ||
26 | please git-clang-format the patch. | |
58 | range loop? | |
lib/Target/HSAIL/HSAILAsmPrinter.h | ||
33 | Start functions with lowercase letter when you can (or is this missing an override?) | |
lib/Target/HSAIL/HSAILSection.cpp | ||
15 | Just don't create sections instead of having empty section switching. |
Just some codingstyle issues I found while skimming over a few files
lib/Target/HSAIL/AMDOpenCLKernenv.h | ||
---|---|---|
10–12 | Needs three slashes. There are similar problems in many of the other files. | |
16–17 | Should be changed to LIB_TARGET_HSAIL_AMDOPENCLKERNELENV_H. There are similar issues in other headers. | |
lib/Target/HSAIL/HSAIL.h | ||
25–43 | Better use static const unsigned or enum values so debuggers can pick those constants up as well. | |
217–221 | Could use doxygen comments here: GENERIC, ///< No target specific flavor ... | |
lib/Target/HSAIL/HSAILAlwaysInlinePass.cpp | ||
24 | Would be nice to name the file like the class declared inside. | |
test/CodeGen/HSAIL/128bit-kernel-args.ll | ||
1 | Many of the tests define new prefixes instead of just using "CHECK" should be unnecessary if you just test for 1 variant anyway. |
include/llvm/Support/ELF.h | ||
---|---|---|
237 | This is being requested | |
lib/Target/HSAIL/HSAILAlwaysInlinePass.cpp | ||
60 | I fixed this in the AMDGPU copy of this pass, so once http://reviews.llvm.org/D11155 is in I'll just remove this file. | |
lib/Target/HSAIL/HSAILSection.cpp | ||
17 | These sections are created by the generic code in the AsmPrinter. This is exactly what NVPTX does currently to fix this. | |
test/CodeGen/HSAIL/128bit-kernel-args.ll | ||
3 | People have expressed regret as having a default of CHECK for this before. The idea is someday it might be useful to add an HSAIL64 or something like that someday. |
lib/Target/HSAIL/HSAILISelDAGToDAG.cpp | ||
---|---|---|
607–609 | This could probably be simplified a lot. The cases for ADD/OR looks unnecessary. It seems to mostly be to workaround the ADD -> OR combine. I don't think LDA needs to be handled here at all. I fixed it so that global addresses are handled during selection, so this shouldn't be seeing the custom node (which doesn't seem to be used anymore) | |
lib/Target/HSAIL/MCTargetDesc/RawVectorOstream.h | ||
24–26 | I think I can completely remove this for now since it should only be used by the BRIGAsmPrinter |
I don't see these in http://www.sco.com/developers/gabi/latest/ch4.eheader.html.