Just includes patch to add bulk of target, not tests or other prerequisite patches.
I don't see these in http://www.sco.com/developers/gabi/latest/ch4.eheader.html.
No commented out code please.
Don't repeat names in comments.
please git-clang-format the patch.
Start functions with lowercase letter when you can (or is this missing an override?)
Just don't create sections instead of having empty section switching.
Just some codingstyle issues I found while skimming over a few files
Needs three slashes. There are similar problems in many of the other files.
Should be changed to LIB_TARGET_HSAIL_AMDOPENCLKERNELENV_H. There are similar issues in other headers.
Better use static const unsigned or enum values so debuggers can pick those constants up as well.
Could use doxygen comments here:
GENERIC, ///< No target specific flavor ...
Would be nice to name the file like the class declared inside.
Many of the tests define new prefixes instead of just using "CHECK" should be unnecessary if you just test for 1 variant anyway.
This is being requested
I fixed this in the AMDGPU copy of this pass, so once http://reviews.llvm.org/D11155 is in I'll just remove this file.
These sections are created by the generic code in the AsmPrinter. This is exactly what NVPTX does currently to fix this.
People have expressed regret as having a default of CHECK for this before. The idea is someday it might be useful to add an HSAIL64 or something like that someday.
This could probably be simplified a lot. The cases for ADD/OR looks unnecessary. It seems to mostly be to workaround the ADD -> OR combine. I don't think LDA needs to be handled here at all. I fixed it so that global addresses are handled during selection, so this shouldn't be seeing the custom node (which doesn't seem to be used anymore)
I think I can completely remove this for now since it should only be used by the BRIGAsmPrinter