This is an archive of the discontinued LLVM Phabricator instance.

Differential D97369

[libcxx] [test] Quote the path to the python interpreter
ClosedPublic

Authored by mstorsjo on Feb 24 2021, 2:24 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGc218c80c730a: [libcxx] [test] Quote the path to the python interpreter
Summary

This should allow running tests with the interpreter in some of the default paths where Python for Windows might be installed.

Diff Detail

Event Timeline

mstorsjo created this revision.Feb 24 2021, 2:24 AM
Herald added a subscriber: mgorny. · View Herald TranscriptFeb 24 2021, 2:24 AM
mstorsjo requested review of this revision.Feb 24 2021, 2:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2021, 2:24 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B90567: Diff 326026.Feb 24 2021, 7:11 AM
ldionne accepted this revision.Feb 24 2021, 7:17 AM
This revision is now accepted and ready to land.Feb 24 2021, 7:17 AM
Closed by commit rGc218c80c730a: [libcxx] [test] Quote the path to the python interpreter (authored by mstorsjo). · Explain WhyFeb 24 2021, 12:26 PM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rGc218c80c730a: [libcxx] [test] Quote the path to the python interpreter.
mstorsjo mentioned this in D97166: [libcxx] [docs] Update docs about how to build for Windows.Mar 1 2021, 1:31 PM

Revision Contents

PathSize
libcxx/
test/
2 lines

Diff 326026

libcxx/test/CMakeLists.txt

Show First 20 Lines • Show All 76 Lines • ▼ Show 20 Lines
# directory. # directory.
if (NOT LIBCXX_CXX_ABI_LIBRARY_PATH) if (NOT LIBCXX_CXX_ABI_LIBRARY_PATH)
set(LIBCXX_CXX_ABI_LIBRARY_PATH "${LIBCXX_LIBRARY_DIR}" CACHE PATH set(LIBCXX_CXX_ABI_LIBRARY_PATH "${LIBCXX_LIBRARY_DIR}" CACHE PATH
"The path to libc++abi library.") "The path to libc++abi library.")
endif() endif()
set(LIBCXX_TARGET_INFO "libcxx.test.target_info.LocalTI" CACHE STRING set(LIBCXX_TARGET_INFO "libcxx.test.target_info.LocalTI" CACHE STRING
"TargetInfo to use when setting up test environment.") "TargetInfo to use when setting up test environment.")
set(LIBCXX_EXECUTOR "${Python3_EXECUTABLE} ${CMAKE_CURRENT_LIST_DIR}/../utils/run.py" CACHE STRING set(LIBCXX_EXECUTOR "\\\"${Python3_EXECUTABLE}\\\" ${CMAKE_CURRENT_LIST_DIR}/../utils/run.py" CACHE STRING
"Executor to use when running tests.") "Executor to use when running tests.")
set(AUTO_GEN_COMMENT "## Autogenerated by libcxx configuration.\n# Do not edit!") set(AUTO_GEN_COMMENT "## Autogenerated by libcxx configuration.\n# Do not edit!")
if (NOT DEFINED LIBCXX_TEST_DEPS) if (NOT DEFINED LIBCXX_TEST_DEPS)
message(FATAL_ERROR "Expected LIBCXX_TEST_DEPS to be defined") message(FATAL_ERROR "Expected LIBCXX_TEST_DEPS to be defined")
endif() endif()
▲ Show 20 Lines • Show All 53 Lines • Show Last 20 Lines