This is an archive of the discontinued LLVM Phabricator instance.

[clang] fix cmake wrong variable name from RTLIBS to RTLIB
AbandonedPublic

Authored by philass on Feb 21 2021, 11:56 PM.

Details

Summary

RTSLIBS should instread be RTLIB

 if (CLANG_DEFAULT_UNWINDLIB STREQUAL "")
   if (CLANG_DEFAULT_RTLIB STREQUAL "libgcc")
     set (CLANG_DEFAULT_UNWINDLIB "libgcc" CACHE STRING "" FORCE)
-  elseif (CLANG_DEFAULT_RTLIBS STREQUAL "libunwind") 
+  elseif (CLANG_DEFAULT_RTLIB STREQUAL "libunwind")
     set (CLANG_DEFAULT_UNWINDLIB "none" CACHE STRING "" FORCE)
   endif()
 endif()

Since CLANG_DEFAULT_RTLIBS should be CLANG_DEFAULT_RTLIB the line

set (CLANG_DEFAULT_UNWINDLIB "none" CACHE STRING "" FORCE)

will never be reached.

This addresses https://bugs.llvm.org/show_bug.cgi?id=48291

Diff Detail

Event Timeline

philass created this revision.Feb 21 2021, 11:56 PM
philass requested review of this revision.Feb 21 2021, 11:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2021, 11:56 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
philass abandoned this revision.May 31 2021, 10:26 PM