The spec doesn't declare it as an enum class (as far as I can read the spec - hopefully someone can doublecheck my reading of it), and being declared as an enum class breaks referring to the values as e.g. path::auto_format.
Details
Details
- Reviewers
ldionne curdeius - Group Reviewers
Restricted Project - Commits
- rG26005c788b06: [libcxx] Make path::format a non-class enum
Diff Detail
Diff Detail
Unit Tests
Unit Tests
Event Timeline
Comment Actions
I think they certainly missed an opportunity to make it an enum class, but you seem to be right.
Ship it with the comment removed.
libcxx/test/std/input.output/filesystems/fs.enum/enum.path.format.pass.cpp | ||
---|---|---|
26 | I don't think this comment applies anymore. |
I don't think this comment applies anymore.