This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Make path::format a non-class enum
ClosedPublic

Authored by mstorsjo on Feb 19 2021, 1:29 PM.

Details

Reviewers
ldionne
curdeius
Group Reviewers
Restricted Project
Commits
rG26005c788b06: [libcxx] Make path::format a non-class enum
Summary

The spec doesn't declare it as an enum class (as far as I can read the spec - hopefully someone can doublecheck my reading of it), and being declared as an enum class breaks referring to the values as e.g. path::auto_format.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Feb 19 2021, 1:29 PM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 19 2021, 1:29 PM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
ldionne accepted this revision.Feb 19 2021, 1:31 PM

I think they certainly missed an opportunity to make it an enum class, but you seem to be right.

Ship it with the comment removed.

libcxx/test/std/input.output/filesystems/fs.enum/enum.path.format.pass.cpp
26

I don't think this comment applies anymore.

This revision is now accepted and ready to land.Feb 19 2021, 1:31 PM
mstorsjo updated this revision to Diff 325196.Feb 20 2021, 5:55 AM
mstorsjo removed rG LLVM Github Monorepo as the repository for this revision.
mstorsjo set the repository for this revision to rG LLVM Github Monorepo.

Rerun CI

This revision was automatically updated to reflect the committed changes.