This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Lower GetRealStopInfo into ThreadPlanCallFunction (NFC)
ClosedPublic

Authored by kastiglione on Feb 14 2021, 11:18 PM.

Details

Summary

GetRealStopInfo has only one call site, and in that call site a reference to the
concrete thread plan is available (ThreadPlanCallUserExpression), from which
GetRealStopInfo can be called.

Diff Detail

Event Timeline

kastiglione requested review of this revision.Feb 14 2021, 11:18 PM
kastiglione created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2021, 11:18 PM
jingham accepted this revision.Feb 15 2021, 2:28 PM

It does seem odd to peek behind the back of a thread plan to figure out how to proceed, so making this special to the UserExpression thread plans, which are special in a bunch of ways, isn't a bad idea.

This revision is now accepted and ready to land.Feb 15 2021, 2:28 PM
This revision was landed with ongoing or failed builds.Feb 15 2021, 6:00 PM
This revision was automatically updated to reflect the committed changes.