This is an archive of the discontinued LLVM Phabricator instance.

Differential D96658

[xray] Fix xray document spelling
ClosedPublic

Authored by yao on Feb 13 2021, 8:24 PM.

Details

Reviewers
dberris
Commits
rG98cbdba2c189: [xray] Fix xray document spelling
Summary

fix a couple of words spelling

Diff Detail

Event Timeline

yao requested review of this revision.Feb 13 2021, 8:24 PM
yao created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 13 2021, 8:24 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B89136: Diff 323591.Feb 13 2021, 9:04 PM
dberris added a comment.Feb 15 2021, 4:52 PM

Thanks for this!

Some of these changes LGTM but the conversions from analyzing to analysing doesn't seem necessary (UK vs US English).

llvm/docs/XRay.rst
29

Thanks, though analysing is also a valid English spelling (not US English).

yao updated this revision to Diff 323868.Feb 15 2021, 8:09 PM

revert the change for "analysing"

dberris accepted this revision.Feb 15 2021, 8:10 PM

LGTM

Thanks!

PS. Do you need someone to land this for you?

This revision is now accepted and ready to land.Feb 15 2021, 8:10 PM
Harbormaster completed remote builds in B89307: Diff 323868.Feb 15 2021, 8:43 PM
yao added a comment.Feb 16 2021, 7:08 PM
In D96658#2564522, @dberris wrote:

LGTM

Thanks!

PS. Do you need someone to land this for you?

I guess I have no permission to commit. If so, please give a hand.

thanks,
yao

yao added a comment.Feb 20 2021, 6:38 PM

Please help to commit

yao added a comment.Mar 3 2021, 7:46 PM

Is it committed?

dberris added a comment.Mar 3 2021, 8:10 PM

Apologies for the delay, not yet. I'm going to land it ~now.

dberris added a comment.Mar 3 2021, 8:20 PM

Actually, looks like this doesn't apply cleanly anymore. Sorry about that, can you rebase?

yao updated this revision to Diff 328509.Mar 5 2021, 6:32 AM

updated.

Harbormaster completed remote builds in B92306: Diff 328509.Mar 6 2021, 12:11 AM
yao added a comment.Mar 9 2021, 5:50 PM

can you please land it? I had already rebased.

dberris added a comment.Mar 9 2021, 7:26 PM

I'm trying to commit it now, but I need some information first: What should I put in the Author: line in the commit?

yao added a comment.Mar 9 2021, 7:39 PM

Yao Zhao
ca.yao.zhao@gmail.com

thanks

Closed by commit rG98cbdba2c189: [xray] Fix xray document spelling (authored by yao, committed by dberris). · Explain WhyMar 9 2021, 9:04 PM
This revision was automatically updated to reflect the committed changes.
dberris added a commit: rG98cbdba2c189: [xray] Fix xray document spelling.

Revision Contents

PathSize
llvm/
docs/
2 lines
2 lines

Diff 328509

llvm/docs/XRay.rst

Context not available.
- Instrumenting your C/C++/Objective-C/Objective-C++ application. - Instrumenting your C/C++/Objective-C/Objective-C++ application.
- Generating LLVM IR with the correct function attributes. - Generating LLVM IR with the correct function attributes.
The rest of this section covers these main ways and later on how to customise The rest of this section covers these main ways and later on how to customize
what XRay does in an XRay-instrumented binary. what XRay does in an XRay-instrumented binary.
Instrumenting your C/C++/Objective-C Application Instrumenting your C/C++/Objective-C Application
Context not available.

llvm/docs/XRayExample.rst

Context not available.
$ XRAY_OPTIONS="patch_premain=true xray_mode=xray-basic" ./sample $ XRAY_OPTIONS="patch_premain=true xray_mode=xray-basic" ./sample
We can then explore the graph rendering of the trace generated by this sample We can then explore the graph rendering of the trace generated by this sample
application. We assume you have the graphviz toosl available in your system, application. We assume you have the graphviz tools available in your system,
including both ``unflatten`` and ``dot``. If you prefer rendering or exploring including both ``unflatten`` and ``dot``. If you prefer rendering or exploring
the graph using another tool, then that should be feasible as well. ``llvm-xray the graph using another tool, then that should be feasible as well. ``llvm-xray
graph`` will create DOT format graphs which should be usable in most graph graph`` will create DOT format graphs which should be usable in most graph
Context not available.