This is an archive of the discontinued LLVM Phabricator instance.

[xray] Fix xray document spelling
ClosedPublic

Authored by yao on Feb 13 2021, 8:24 PM.

Details

Summary

fix a couple of words spelling

Diff Detail

Event Timeline

yao requested review of this revision.Feb 13 2021, 8:24 PM
yao created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 13 2021, 8:24 PM

Thanks for this!

Some of these changes LGTM but the conversions from analyzing to analysing doesn't seem necessary (UK vs US English).

llvm/docs/XRay.rst
29

Thanks, though analysing is also a valid English spelling (not US English).

yao updated this revision to Diff 323868.Feb 15 2021, 8:09 PM

revert the change for "analysing"

dberris accepted this revision.Feb 15 2021, 8:10 PM

LGTM

Thanks!

PS. Do you need someone to land this for you?

This revision is now accepted and ready to land.Feb 15 2021, 8:10 PM
yao added a comment.Feb 16 2021, 7:08 PM

LGTM

Thanks!

PS. Do you need someone to land this for you?

I guess I have no permission to commit. If so, please give a hand.

thanks,
yao

yao added a comment.Feb 20 2021, 6:38 PM

Please help to commit

yao added a comment.Mar 3 2021, 7:46 PM

Is it committed?

Apologies for the delay, not yet. I'm going to land it ~now.

Actually, looks like this doesn't apply cleanly anymore. Sorry about that, can you rebase?

yao updated this revision to Diff 328509.Mar 5 2021, 6:32 AM

updated.

yao added a comment.Mar 9 2021, 5:50 PM

can you please land it? I had already rebased.

I'm trying to commit it now, but I need some information first: What should I put in the Author: line in the commit?

yao added a comment.Mar 9 2021, 7:39 PM

Yao Zhao
ca.yao.zhao@gmail.com

thanks

This revision was automatically updated to reflect the committed changes.