This is an archive of the discontinued LLVM Phabricator instance.

[MIRLangRef] Document MachineOperand comments
ClosedPublic

Authored by SjoerdMeijer on Feb 11 2021, 8:49 AM.

Details

Summary

Late follow-up of D74306 to document MachineOperand comments in MIRLangRef.

Diff Detail

Event Timeline

SjoerdMeijer created this revision.Feb 11 2021, 8:49 AM
SjoerdMeijer requested review of this revision.Feb 11 2021, 8:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2021, 8:49 AM
dmgreen accepted this revision.Feb 12 2021, 12:37 AM

Sounds good to me.

(Although, I would move it out from the middle of the "Operands" section. Maybe to after Predicate Operands, so it's still in "Machine Operands" but not between two other Operand types)

This revision is now accepted and ready to land.Feb 12 2021, 12:37 AM

Thanks Dave, I will move it before committing.

This revision was automatically updated to reflect the committed changes.