This is an archive of the discontinued LLVM Phabricator instance.

[zorg] Disable test-suite for arm global-isel bots
AbandonedPublic

Authored by zatrazz on Feb 11 2021, 4:54 AM.

Details

Summary

Since global-isel is only enable at -O0 and it triggers the
https://bugs.llvm.org/show_bug.cgi?id=49143 issue.

Diff Detail

Event Timeline

zatrazz created this revision.Feb 11 2021, 4:54 AM
zatrazz requested review of this revision.Feb 11 2021, 4:54 AM
ostannard requested changes to this revision.Feb 11 2021, 5:46 AM
ostannard added a subscriber: ostannard.

The test-suite is the only thing this bot does to test global-isel, so I don't think there's any point in running the bot with this change. I think our options here are:

  • Disable just the tests which are failing (looks like it's just test-suite::GCC-C-execute-eeprof-1.test?)
  • Convert this to a 2-stage bot with the second stage built using global-isel, so that we are still doing some useful testing
  • Disable this bot completely until https://bugs.llvm.org/show_bug.cgi?id=49143 is fixed.
This revision now requires changes to proceed.Feb 11 2021, 5:46 AM

The test-suite is the only thing this bot does to test global-isel, so I don't think there's any point in running the bot with this change. I think our options here are:

  • Disable just the tests which are failing (looks like it's just test-suite::GCC-C-execute-eeprof-1.test?)
  • Convert this to a 2-stage bot with the second stage built using global-isel, so that we are still doing some useful testing
  • Disable this bot completely until https://bugs.llvm.org/show_bug.cgi?id=49143 is fixed.

This patch was meant to disable the bots while I get the https://bugs.llvm.org/show_bug.cgi?id=49143 fixed, but I got you point. Turning into a 2-stage bot it not really feasible because afaik even with lld linking fails with OOM with Debug on 32-bit architectures. I think maybe we can disable the the specific test on test-suite, however I am not sure if the the correct approach.

There are lists of tests to skip for each architecture in SingleSource/Regression/C/gcc-c-torture/execute/CMakeLists.txt, that looks like the right place to do this. I'm not sure if it's possible to know if global-isel is enabled in that file, but since it's just one test I think disabling it for all Arm and AArch64 bots is ok.

zatrazz abandoned this revision.Feb 11 2021, 8:57 AM