This is an archive of the discontinued LLVM Phabricator instance.

Differential D96254

[ELFObjectWriter] Fix `symbol-binding.test` to conform to unsorted local symbols
AbandonedPublic

Authored by frgossen on Feb 8 2021, 3:26 AM.

Details

Reviewers
bkramer
MaskRay
Summary

Commit 980d28d9556a (ELFObjectWriter: Don't sort local symbols) caused
symbol-binding.test to fail (see
http://lab.llvm.org:8011/#/builders/96/builds/4268).

Diff Detail

Event Timeline

frgossen requested review of this revision.Feb 8 2021, 3:26 AM
frgossen created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2021, 3:26 AM
Herald added a subscriber: lldb-commits. · View Herald Transcript
frgossen added reviewers: bkramer, MaskRay.Feb 8 2021, 3:32 AM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptFeb 8 2021, 3:32 AM
Harbormaster completed remote builds in B88265: Diff 322068.Feb 8 2021, 3:55 AM
frgossen abandoned this revision.Feb 8 2021, 4:04 AM

Already fixed in d813c37fc7ce507e008bdee1fc1726a57bc76df5

Revision Contents

PathSize
lldb/
test/
Shell/
SymbolFile/
8 lines

Diff 322068

lldb/test/Shell/SymbolFile/symbol-binding.test

# Some targets do not have the .size directive. # Some targets do not have the .size directive.
# RUN: %clang -target x86_64-unknown-unknown-elf %S/Inputs/symbol-binding.s -c -o %t.o # RUN: %clang -target x86_64-unknown-unknown-elf %S/Inputs/symbol-binding.s -c -o %t.o
# RUN: %lldb %t.o -s %s -o quit | FileCheck %s # RUN: %lldb %t.o -s %s -o quit | FileCheck %s
image lookup --address 4 image lookup --address 4
# CHECK: Summary: symbol-binding.test.tmp.o`case1_global # CHECK: Summary: symbol-binding.test.tmp.o`case1_global
image lookup --address 5 image lookup --address 5
# CHECK: Summary: symbol-binding.test.tmp.o`case2_weak # CHECK: Summary: symbol-binding.test.tmp.o`case2_weak
image lookup --address 6 image lookup --address 6
# CHECK: Summary: symbol-binding.test.tmp.o`case3_global # CHECK: Summary: symbol-binding.test.tmp.o`case3_global
image dump symtab image dump symtab
# CHECK: Index UserID DSX Type File Address/Value Load Address Size Flags Name # CHECK: Index UserID DSX Type File Address/Value Load Address Size Flags Name
# CHECK-NEXT:------- ------ --- --------------- ------------------ ------------------ ------------------ ---------- ---------------------------------- # CHECK-NEXT:------- ------ --- --------------- ------------------ ------------------ ------------------ ---------- ----------------------------------
# CHECK-NEXT:[ 0] 1 Code 0x0000000000000004 0x0000000000000001 0x00000000 case1_local # CHECK-NEXT:[ 0] 1 Code 0x0000000000000001 0x0000000000000002 0x00000000 sizeless
# CHECK-NEXT:[ 1] 2 Code 0x0000000000000005 0x0000000000000001 0x00000000 case2_local # CHECK-NEXT:[ 1] 2 Code 0x0000000000000001 0x0000000000000002 0x00000000 sizeful
# CHECK-NEXT:[ 2] 3 Code 0x0000000000000003 0x0000000000000001 0x00000000 sizeend # CHECK-NEXT:[ 2] 3 Code 0x0000000000000003 0x0000000000000001 0x00000000 sizeend
# CHECK-NEXT:[ 3] 4 Code 0x0000000000000001 0x0000000000000002 0x00000000 sizeful # CHECK-NEXT:[ 3] 4 Code 0x0000000000000004 0x0000000000000001 0x00000000 case1_local
# CHECK-NEXT:[ 4] 5 Code 0x0000000000000001 0x0000000000000002 0x00000000 sizeless # CHECK-NEXT:[ 4] 5 Code 0x0000000000000005 0x0000000000000001 0x00000000 case2_local
# CHECK-NEXT:[ 5] 6 X Code 0x0000000000000004 0x0000000000000001 0x00000010 case1_global # CHECK-NEXT:[ 5] 6 X Code 0x0000000000000004 0x0000000000000001 0x00000010 case1_global
# CHECK-NEXT:[ 6] 7 Code 0x0000000000000005 0x0000000000000001 0x00000020 case2_weak # CHECK-NEXT:[ 6] 7 Code 0x0000000000000005 0x0000000000000001 0x00000020 case2_weak
# CHECK-NEXT:[ 7] 8 X Code 0x0000000000000006 0x0000000000000001 0x00000010 case3_global # CHECK-NEXT:[ 7] 8 X Code 0x0000000000000006 0x0000000000000001 0x00000010 case3_global
# CHECK-NEXT:[ 8] 9 Code 0x0000000000000006 0x0000000000000001 0x00000020 case3_weak # CHECK-NEXT:[ 8] 9 Code 0x0000000000000006 0x0000000000000001 0x00000020 case3_weak