Page MenuHomePhabricator

[lldb] Use assertIn/NotIn over assertTrue/False (NFC)
ClosedPublic

Authored by kastiglione on Feb 4 2021, 5:56 PM.

Details

Summary

For improved failure messages, use assertIn over assertTrue.

Diff Detail

Unit TestsFailed

TimeTest
130 msx64 debian > LLVM.Transforms/LoopVectorize/ARM::mve-gather-scatter-tailpred.ll
Script: -- : 'RUN: at line 2'; /mnt/disks/ssd0/agent/llvm-project/build/bin/opt -loop-vectorize -force-vector-width=4 -mtriple=thumbv8.1m.main-none-none-eabi -mattr=+mve.fp -tail-predication=force-enabled -S /mnt/disks/ssd0/agent/llvm-project/llvm/test/Transforms/LoopVectorize/ARM/mve-gather-scatter-tailpred.ll -o - | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck --allow-unused-prefixes=false /mnt/disks/ssd0/agent/llvm-project/llvm/test/Transforms/LoopVectorize/ARM/mve-gather-scatter-tailpred.ll
140 msx64 windows > LLVM.Transforms/LoopVectorize/ARM::mve-gather-scatter-tailpred.ll
Script: -- : 'RUN: at line 2'; c:\ws\w16c2-1\llvm-project\premerge-checks\build\bin\opt.exe -loop-vectorize -force-vector-width=4 -mtriple=thumbv8.1m.main-none-none-eabi -mattr=+mve.fp -tail-predication=force-enabled -S C:\ws\w16c2-1\llvm-project\premerge-checks\llvm\test\Transforms\LoopVectorize\ARM\mve-gather-scatter-tailpred.ll -o - | c:\ws\w16c2-1\llvm-project\premerge-checks\build\bin\filecheck.exe --allow-unused-prefixes=false C:\ws\w16c2-1\llvm-project\premerge-checks\llvm\test\Transforms\LoopVectorize\ARM\mve-gather-scatter-tailpred.ll

Event Timeline

kastiglione requested review of this revision.Feb 4 2021, 5:56 PM
kastiglione created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2021, 5:56 PM
This revision is now accepted and ready to land.Feb 4 2021, 6:13 PM
This revision was landed with ongoing or failed builds.Feb 6 2021, 11:52 AM
This revision was automatically updated to reflect the committed changes.