This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Require C++20 to build the benchmarks.
ClosedPublic

Authored by Mordante on Feb 4 2021, 9:41 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG34acc9164244: [libc++] Require C++20 to build the benchmarks.
Summary

Some work-in-progress patches for the format header contain benchmarks.
The format header requires C++20 to build. This is a preparation to make
it easy to add these benchmarks.

Diff Detail

Event Timeline

Mordante created this revision.Feb 4 2021, 9:41 AM
Mordante requested review of this revision.Feb 4 2021, 9:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2021, 9:41 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Feb 9 2021, 8:43 AM

This LGTM, let's see if other build bots not covered by our CI complain.

If they do, then we need to migrate them to our CI :-).

This revision is now accepted and ready to land.Feb 9 2021, 8:43 AM
ldionne added inline comments.Feb 9 2021, 8:44 AM
libcxx/docs/ReleaseNotes.rst
41

I would move this to API changes, though. It's not really a feature. No need to update the review.

Mordante marked an inline comment as done.Feb 9 2021, 9:33 AM

This LGTM, let's see if other build bots not covered by our CI complain.

If they do, then we need to migrate them to our CI :-).

If it's that easy ;-)

This revision was automatically updated to reflect the committed changes.

The sanitizer-ppc64be-linux build node uses gcc 7.3.1 and fails http://lab.llvm.org:8011/#/builders/18/builds/749