This is an archive of the discontinued LLVM Phabricator instance.

Differential D95954

[NFC] Use the same type for bit fields in MCSchedClassDesc
ClosedPublic

Authored by asavonic on Feb 3 2021, 7:24 AM.

Details

Reviewers
RKSimon
Commits
rG4bee0dc918d2: [NFC] Use the same type for bit fields in MCSchedClassDesc
Summary

Otherwise they are not allocated as a single bit field and take 4
bytes instead of 2.

Diff Detail

Event Timeline

asavonic requested review of this revision.Feb 3 2021, 7:24 AM
asavonic created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 3 2021, 7:24 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
asavonic mentioned this in D94928: [llvm-mca] Add support for in-order CPUs.Feb 3 2021, 7:26 AM
Harbormaster completed remote builds in B87705: Diff 321098.Feb 3 2021, 8:34 AM
RKSimon accepted this revision.Feb 3 2021, 8:52 AM

LGTM - thanks

This revision is now accepted and ready to land.Feb 3 2021, 8:52 AM
This revision was landed with ongoing or failed builds.Feb 17 2021, 4:59 AM
Closed by commit rG4bee0dc918d2: [NFC] Use the same type for bit fields in MCSchedClassDesc (authored by asavonic). · Explain Why
This revision was automatically updated to reflect the committed changes.
asavonic added a commit: rG4bee0dc918d2: [NFC] Use the same type for bit fields in MCSchedClassDesc.

Revision Contents

PathSize
llvm/
include/
llvm/
MC/
4 lines

Diff 324276

llvm/include/llvm/MC/MCSchedule.h

Show First 20 Lines • Show All 109 Lines • ▼ Show 20 Lines
struct MCSchedClassDesc { struct MCSchedClassDesc {
static const unsigned short InvalidNumMicroOps = (1U << 14) - 1; static const unsigned short InvalidNumMicroOps = (1U << 14) - 1;
static const unsigned short VariantNumMicroOps = InvalidNumMicroOps - 1; static const unsigned short VariantNumMicroOps = InvalidNumMicroOps - 1;
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
const char* Name; const char* Name;
#endif #endif
uint16_t NumMicroOps : 14; uint16_t NumMicroOps : 14;
bool BeginGroup : 1; uint16_t BeginGroup : 1;
bool EndGroup : 1; uint16_t EndGroup : 1;
uint16_t WriteProcResIdx; // First index into WriteProcResTable. uint16_t WriteProcResIdx; // First index into WriteProcResTable.
uint16_t NumWriteProcResEntries; uint16_t NumWriteProcResEntries;
uint16_t WriteLatencyIdx; // First index into WriteLatencyTable. uint16_t WriteLatencyIdx; // First index into WriteLatencyTable.
uint16_t NumWriteLatencyEntries; uint16_t NumWriteLatencyEntries;
uint16_t ReadAdvanceIdx; // First index into ReadAdvanceTable. uint16_t ReadAdvanceIdx; // First index into ReadAdvanceTable.
uint16_t NumReadAdvanceEntries; uint16_t NumReadAdvanceEntries;
bool isValid() const { bool isValid() const {
▲ Show 20 Lines • Show All 258 Lines • Show Last 20 Lines