Page MenuHomePhabricator

[GWP-ASan] Add locking around unwinder for atfork protection.
ClosedPublic

Authored by hctim on Feb 2 2021, 11:48 AM.

Details

Summary

Unwinders (like libc's backtrace()) can call their own locks (like the
libdl lock). We need to let the unwinder release the locks before
forking. Wrap a new lock around the unwinder for atfork protection.

Diff Detail

Event Timeline

hctim requested review of this revision.Feb 2 2021, 11:48 AM
hctim created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2021, 11:48 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
eugenis accepted this revision.Feb 2 2021, 2:29 PM

LGTM

This revision is now accepted and ready to land.Feb 2 2021, 2:29 PM
This revision was landed with ongoing or failed builds.Feb 2 2021, 2:45 PM
This revision was automatically updated to reflect the committed changes.