Page MenuHomePhabricator

[PATCH] libsanitizer: Support non-POSIX extension REG_STARTEND.
AbandonedPublic

Authored by marxin on Feb 2 2021, 4:51 AM.

Details

Reviewers
kcc
vitalybuka
Summary

A recent (15 years old) glibc is needed in order to support
REG_STARTEND.

The patch addresses problem reported here:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98920

Diff Detail

Event Timeline

marxin requested review of this revision.Feb 2 2021, 4:51 AM
marxin created this revision.
marxin edited the summary of this revision. (Show Details)
marxin updated this revision to Diff 322401.Feb 9 2021, 8:25 AM

There is D96348

Ahh, good. That's addressing the very same issue.

arichardson added inline comments.
compiler-rt/lib/sanitizer_common/sanitizer_platform.h
353

Is this missing SANITIZER_I386?

Having to hardcode all the architectures is rather awkward, maybe we should just fall back to an unversioned lookup if the versioned one fails?

marxin added inline comments.Feb 19 2021, 5:48 AM
compiler-rt/lib/sanitizer_common/sanitizer_platform.h
353

Yes, doing an unversioned fallback would be the best approach! Can you please do it in your patch submission?
I tend to close this review request.

marxin abandoned this revision.Feb 19 2021, 5:50 AM