Remove tailing " (deleted)" from executable name returned by readlink

[chying]

Summary

When calling readlink, " (deleted)" is appended to executable path if it's deleted. Remove if it's there.

[sivachandra]

LGTM. Please wait for chaoren.

[chaoren]

test/tools/lldb-server/gdbremote_testcase.py

164

shell_command.GetOutput().replace('(deleted)', '').strip()

No functional difference, but I think this looks nicer.

Also, what if someone puts their lldb-server binary in a path containing the word ' (deleted)'? You never know. :)

E.g., '/usr/ (deleted)/bin/lldb-server'

[chying]

Remove ' (deleted)' only if it comes at the last

[chaoren]

test/tools/lldb-server/gdbremote_testcase.py

164

re.sub(' \(deleted\)$', '', shell_command.GetOutput().strip())

For most correctness.

[chying]

use re to match the pattern

test/tools/lldb-server/gdbremote_testcase.py

def init_llgs_test(self, use_named_pipe=True):
             if err.Fail():
                 raise Exception("remote_platform.RunShellCommand('echo $PPID') failed: %s" % err)
             pid = shell_command.GetOutput().strip()
 
             shell_command = lldb.SBPlatformShellCommand("readlink /proc/%s/exe" % pid)
             err = platform.Run(shell_command)
             if err.Fail():
                 raise Exception("remote_platform.RunShellCommand('readlink /proc/%d/exe') failed: %s" % (pid, err))
-            self.debug_monitor_exe = shell_command.GetOutput().strip()
+            // If the binary has been deleted, the link name has " (deleted)" appended.
+            // Remove if it's there.
+            self.debug_monitor_exe = re.sub(r' \(deleted\)$', '', shell_command.GetOutput().strip())
             dname = self.dbg.GetSelectedPlatform().GetWorkingDirectory()
         else:
             self.debug_monitor_exe = get_lldb_server_exe()
             if not self.debug_monitor_exe:
                 self.skipTest("lldb-server exe not found")
             dname = os.path.join(os.environ["LLDB_TEST"], os.environ["LLDB_SESSION_DIRNAME"])
 
         self.debug_monitor_extra_args = ["gdbserver", "-c", "log enable -T -f {}/process-{}.log lldb break process thread".format(dname, self.id()), "-c", "log enable -T -f {}/packets-{}.log gdb-remote packets".format(dname, self.id())]