Page MenuHomePhabricator

chying (Ying Chen)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2015, 1:30 PM (252 w, 3 d)

Recent Activity

Aug 30 2016

chying accepted D24062: Removed warnOnFailure flag for the step for running NDK update script..

looks good.

Aug 30 2016, 4:42 PM
chying added a comment to D24062: Removed warnOnFailure flag for the step for running NDK update script..

Could you also set haltOnFailure=False, so that build continues if this step fails?

Aug 30 2016, 4:16 PM

Jul 21 2016

chying accepted D22552: [zorg] Add a step to run NDK update step to the scripted LLDB builder.

looks good.

Jul 21 2016, 3:00 PM

Jul 7 2016

chying accepted D22097: [zorg] Remove flunkOnFailure=False from the scripted LLDB builder.

Looks good.

Jul 7 2016, 11:32 AM

Jun 8 2016

chying accepted D21159: [zorg] Add a step to run unit tests to the scripted LLDB builder.

thanks for making the changes, look good.

Jun 8 2016, 7:03 PM

Apr 6 2016

chying added a comment to D18819: Reduce code duplication in ProcessGDBRemote.

TestRegisters.py and TestDebugBreak.py are broken after this change. Could you take a look?
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/13090

Apr 6 2016, 11:12 AM

Mar 25 2016

chying added a comment to D18481: Add argument to expectedFailureAll decorator to xfail for environment variables, and xfail tests for hard float abi and -mthumb on android arm.

Couldn't we have a way to say in the Makefile "never use these flags", then the test suite could check the environment and remove them if they are present. This woudl allow the test to run.

architecture, compiler, etc are things we don't really have control over. If a flag or an environment variable is causing a test to fail, it seems like the right thing to do is not to use that flag or environment variable.

Mar 25 2016, 2:58 PM
chying retitled D18481: Add argument to expectedFailureAll decorator to xfail for environment variables, and xfail tests for hard float abi and -mthumb on android arm from to Add argument to expectedFailureAll decorator to xfail for environment variables, and xfail tests for hard float abi and -mthumb on android arm.
Mar 25 2016, 1:12 PM

Mar 2 2016

chying added a comment to D17363: Add SymbolFilePDB with basic support for line tables..

Yes, it is fixed now. Thank you!

Mar 2 2016, 5:55 PM
chying added a comment to D17363: Add SymbolFilePDB with basic support for line tables..

Seems this patch breaks OSX build. I guess the new files were not added to xcode project file.
Could you please take a look?
http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/8892/steps/ninja%20build%20local/logs/stdio

Mar 2 2016, 5:10 PM

Jan 8 2016

chying committed rL257228: Fix TestDebugBreak.py failure with gcc, for loop declarations are not allowed….
Fix TestDebugBreak.py failure with gcc, for loop declarations are not allowed…
Jan 8 2016, 3:14 PM

Dec 9 2015

chying committed rL255145: [zorg] Add failing code "ERROR" to buildbot step results in LitTestCommand.
[zorg] Add failing code "ERROR" to buildbot step results in LitTestCommand
Dec 9 2015, 11:52 AM

Nov 23 2015

chying committed rL253939: Update comments for r253756.
Update comments for r253756
Nov 23 2015, 3:42 PM

Nov 20 2015

chying committed rL253756: Add one more non-flunk test slot for LLDBBuilder.
Add one more non-flunk test slot for LLDBBuilder
Nov 20 2015, 5:49 PM

Nov 18 2015

chying committed rL253488: Support unix-abstract-connect scheme as platform url in lldb testsuite.
Support unix-abstract-connect scheme as platform url in lldb testsuite
Nov 18 2015, 11:06 AM
chying closed D14765: Support unix-abstract-connect scheme as platform url in lldb testsuite by committing rL253488: Support unix-abstract-connect scheme as platform url in lldb testsuite.
Nov 18 2015, 11:06 AM
chying added a comment to D14765: Support unix-abstract-connect scheme as platform url in lldb testsuite.
Nov 18 2015, 11:05 AM

Nov 17 2015

chying added inline comments to D14765: Support unix-abstract-connect scheme as platform url in lldb testsuite.
Nov 17 2015, 7:34 PM
chying updated the diff for D14765: Support unix-abstract-connect scheme as platform url in lldb testsuite.

Address comments.

Nov 17 2015, 7:32 PM
chying retitled D14765: Support unix-abstract-connect scheme as platform url in lldb testsuite from to Support unix-abstract-connect scheme as platform url in lldb testsuite.
Nov 17 2015, 5:30 PM

Nov 16 2015

chying committed rL253272: Re-Apply "Add a "not_in()" function you can apply to the list type arguments….
Re-Apply "Add a "not_in()" function you can apply to the list type arguments…
Nov 16 2015, 3:43 PM
chying closed D14673: Fix buildbot breakage after r253106 by committing rL253272: Re-Apply "Add a "not_in()" function you can apply to the list type arguments….
Nov 16 2015, 3:43 PM
chying updated the diff for D14673: Fix buildbot breakage after r253106.

Rebase on the latest commit.

Nov 16 2015, 3:26 PM
chying added a comment to D14673: Fix buildbot breakage after r253106.

Ahh, sorry. I litearlly just committed a change to the same function. You may have to do a merge, sorry about that.

Nov 16 2015, 2:53 PM
chying updated the diff for D14673: Fix buildbot breakage after r253106.

Recommit r253106 - Add a "not_in()" function you can apply to the list type arguments to expectedFailureAll ...
Initialize self.debug_info in Base::setUp()
Check for None before calling "value in list"

Nov 16 2015, 2:42 PM
chying added a comment to D14673: Fix buildbot breakage after r253106.

The compiler None check is because inside of check_list_or_lambda function, it checks for "value in list_or_lamda", which will throw exception if value is None
I agree that the code will be cleaner if debug_info is initialized to None.
Will try to upload another patch soon.

Nov 16 2015, 11:38 AM

Nov 13 2015

chying added a comment to D14673: Fix buildbot breakage after r253106.

I guess this is ok. I don't like raising the None check outside the function, but I don't see another way that isn't more convoluted.

However, I think you still need to fix the grouping of the parentheses. the compiler is None should not override the version check.

Nov 13 2015, 7:24 PM
chying retitled D14673: Fix buildbot breakage after r253106 from to Fix buildbot breakage after r253106.
Nov 13 2015, 6:57 PM

Nov 12 2015

chying committed rL252980: Revert "Another little stepping optimization: if any of the source step….
Revert "Another little stepping optimization: if any of the source step…
Nov 12 2015, 4:33 PM

Oct 20 2015

chying committed rL250871: Set "lldb-amd64-ninja-netbsd7" builder not to download android binaries..
Set "lldb-amd64-ninja-netbsd7" builder not to download android binaries.
Oct 20 2015, 5:57 PM

Sep 23 2015

chying committed rL248434: Check existence of SIGHUP before using it.
Check existence of SIGHUP before using it
Sep 23 2015, 3:03 PM
chying closed D13114: Check existence of SIGHUP before using it by committing rL248434: Check existence of SIGHUP before using it.
Sep 23 2015, 2:59 PM
chying retitled D13114: Check existence of SIGHUP before using it from to Check existence of SIGHUP before using it.
Sep 23 2015, 1:01 PM

Sep 17 2015

chying committed rL247950: [zorg] For lldb builders, add step 'update scripts' to download scripts from….
[zorg] For lldb builders, add step 'update scripts' to download scripts from…
Sep 17 2015, 2:43 PM

Sep 8 2015

chying abandoned D11617: xfail TestCModules.py on Darwin.
Sep 8 2015, 2:54 PM

Sep 4 2015

chying accepted D12650: Convert "long" input to "long long" in typemap for lldb::tid_t..

looks good.
Fix the test failure on Windows to Android.

Sep 4 2015, 3:15 PM

Sep 3 2015

chying accepted D12612: Fix dotest on Windows after multiprocessing refactor.

This patch works for me.
Although I thought we could put less code in main() function.
Then have
if name == "main":

main()

But that will require some more work to refactor the code. Probably that could wait for Todd's clean up.

Sep 3 2015, 4:02 PM
chying added a comment to D12587: Roll dosep.py parallel test runner into dotest.py command line.

Sorry, coming late to this thread.
This change works ok on linux and darwin systems.

Sep 3 2015, 3:51 PM
chying added a comment to D12587: Roll dosep.py parallel test runner into dotest.py command line.

Sorry, coming late to this thread.
This change works ok on linux and darwin systems.

Sep 3 2015, 3:06 PM
chying committed rL246791: Fix TestCompletion.py failure on Darwin after r246639.
Fix TestCompletion.py failure on Darwin after r246639
Sep 3 2015, 11:30 AM
chying closed D12584: Fix TestCompletion.py failure on Darwin after r246639 by committing rL246791: Fix TestCompletion.py failure on Darwin after r246639.
Sep 3 2015, 11:30 AM
chying added a comment to D12584: Fix TestCompletion.py failure on Darwin after r246639.

Based on experiment I had, we need to send empty lines the same times as the number of lines in original commands on Darwin.
But on Linux, only one empty line is needed for multiple lines of commands.
It seems on Darwin, lldb doesn't automatically execute commands separated by new line.

Sep 3 2015, 11:03 AM

Sep 2 2015

chying retitled D12584: Fix TestCompletion.py failure on Darwin after r246639 from to Fix TestCompletion.py failure on Darwin after r246639.
Sep 2 2015, 7:13 PM

Aug 28 2015

chying committed rL246308: Create scheduler class LLDBTriggerable for LLDB Android builders.
Create scheduler class LLDBTriggerable for LLDB Android builders
Aug 28 2015, 10:53 AM
chying closed D12419: Create scheduler class LLDBTriggerable for LLDB Android builders by committing rL246308: Create scheduler class LLDBTriggerable for LLDB Android builders.
Aug 28 2015, 10:53 AM

Aug 27 2015

chying updated the diff for D12419: Create scheduler class LLDBTriggerable for LLDB Android builders.

Remove unused imports

Aug 27 2015, 7:42 PM
chying updated the diff for D12419: Create scheduler class LLDBTriggerable for LLDB Android builders.

A few improvements for class design

Aug 27 2015, 7:37 PM
chying retitled D12419: Create scheduler class LLDBTriggerable for LLDB Android builders from to Create scheduler class LLDBTriggerable for LLDB Android builders.
Aug 27 2015, 5:34 PM

Aug 20 2015

chying added a comment to D11947: Improve instruction emulation based stack unwinding.

It seems a bunch of darwin->android_arm tests are broken after this patch.
Could you take a look?
Here is the first build after this patch.
http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/4977/steps/test7/logs/stdio

Aug 20 2015, 3:04 PM

Aug 12 2015

chying committed rL244830: [zorg] move lldb-android-buildserver out from experimental category.
[zorg] move lldb-android-buildserver out from experimental category
Aug 12 2015, 4:12 PM
chying committed rL244824: [zorg] for lldb android builders, pass 'totBuild' to acquire/release lock script.
[zorg] for lldb android builders, pass 'totBuild' to acquire/release lock script
Aug 12 2015, 3:45 PM

Aug 11 2015

chying accepted D11962: Mark TestCModules as XFAIL on OSX.

Sorry I mean in the code, like,
@expectedFailureDarwin('llvm.org/pr24302')
Otherwise, looks good to me.

Aug 11 2015, 7:06 PM
chying committed rL244704: [zorg] Add steps to acquire and release lock at the start and end of lldb….
[zorg] Add steps to acquire and release lock at the start and end of lldb…
Aug 11 2015, 5:27 PM
chying added a comment to D11962: Mark TestCModules as XFAIL on OSX.

Could you add the related bug to comments or argument?
llvm.org/pr24302

Aug 11 2015, 5:04 PM
chying committed rL244688: [zorg] Use better description for test steps of lldb builder.
[zorg] Use better description for test steps of lldb builder
Aug 11 2015, 3:34 PM

Aug 10 2015

chying committed rL244539: [zorg] Set updateSourceStamp to False for lldb android triggerable scheduler.
[zorg] Set updateSourceStamp to False for lldb android triggerable scheduler
Aug 10 2015, 5:10 PM

Jul 29 2015

chying retitled D11617: xfail TestCModules.py on Darwin from to xfail TestCModules.py on Darwin.
Jul 29 2015, 5:48 PM

Jul 27 2015

chying committed rL243332: Fix Windows buildbot failure after rev 243301.
Fix Windows buildbot failure after rev 243301
Jul 27 2015, 2:47 PM

Jul 24 2015

chying committed rL243177: [zorg] Pass buildnumber and buildername to upload test traces script.
[zorg] Pass buildnumber and buildername to upload test traces script
Jul 24 2015, 4:09 PM
chying committed rL243172: [zorg] Add lldb build factory that launches scripts on slave machine.
[zorg] Add lldb build factory that launches scripts on slave machine
Jul 24 2015, 3:04 PM
chying closed D11445: [zorg] Add lldb build factory that launches scripts on slave machine by committing rL243172: [zorg] Add lldb build factory that launches scripts on slave machine.
Jul 24 2015, 3:04 PM
chying added inline comments to D11445: [zorg] Add lldb build factory that launches scripts on slave machine.
Jul 24 2015, 12:53 PM
chying updated the diff for D11445: [zorg] Add lldb build factory that launches scripts on slave machine.

Address code review feedback

Jul 24 2015, 12:51 PM
chying added inline comments to D11445: [zorg] Add lldb build factory that launches scripts on slave machine.
Jul 24 2015, 12:05 PM
chying added inline comments to D11445: [zorg] Add lldb build factory that launches scripts on slave machine.
Jul 24 2015, 11:53 AM

Jul 22 2015

chying retitled D11445: [zorg] Add lldb build factory that launches scripts on slave machine from to [zorg] Add lldb build factowqry that launches scripts on slave machine.
Jul 22 2015, 7:08 PM

Jul 20 2015

chying committed rL242739: [zorg] clean darwin build folder.
[zorg] clean darwin build folder
Jul 20 2015, 4:51 PM
chying committed rL242699: Enable timeout on Windows.
Enable timeout on Windows
Jul 20 2015, 1:04 PM
chying closed D11368: Enable timeout on Windows by committing rL242699: Enable timeout on Windows.
Jul 20 2015, 1:04 PM
chying retitled D11368: Enable timeout on Windows from to Enable timeout on Windows.
Jul 20 2015, 1:01 PM

Jul 17 2015

chying committed rL242603: [zorg] Change hostname to 127.0.0.1 for lldb android testing.
[zorg] Change hostname to 127.0.0.1 for lldb android testing
Jul 17 2015, 7:56 PM
chying accepted D11312: Handle altsep ('/' on Windows) in compiler path for log files..

looks good

Jul 17 2015, 2:37 PM
chying added a comment to D11312: Handle altsep ('/' on Windows) in compiler path for log files..

should be
compiler = compiler.replace(os.path.altsep, os.path.sep)?
.replace doesn't change the original copy

Jul 17 2015, 2:33 PM
chying committed rL242556: [zorg]For darwin lldb builder, remove symbolic link at the beginning of build.
[zorg]For darwin lldb builder, remove symbolic link at the beginning of build
Jul 17 2015, 11:23 AM

Jul 16 2015

chying committed rL242502: [zorg]Support separate toolchain locations for android build and test.
[zorg]Support separate toolchain locations for android build and test
Jul 16 2015, 7:44 PM
chying closed D11287: [zorg]Support separate toolchain locations for android build and test by committing rL242502: [zorg]Support separate toolchain locations for android build and test.
Jul 16 2015, 7:44 PM
chying retitled D11287: [zorg]Support separate toolchain locations for android build and test from to [zorg]Support separate toolchain locations for android build and test.
Jul 16 2015, 7:30 PM

Jul 8 2015

chying committed rL241769: Enable mi tests on darwin.
Enable mi tests on darwin
Jul 8 2015, 6:00 PM
chying committed rL241766: Add step to get fingerprint of Android device.
Add step to get fingerprint of Android device
Jul 8 2015, 5:45 PM
chying committed rL241735: Add android test to darwin builder.
Add android test to darwin builder
Jul 8 2015, 2:25 PM
chying closed D10252: Add android test to darwin builder by committing rL241735: Add android test to darwin builder.
Jul 8 2015, 2:25 PM

Jul 1 2015

chying committed rL241203: Mark test_sb_api_listener_event_process_state as flakey.
Mark test_sb_api_listener_event_process_state as flakey
Jul 1 2015, 3:50 PM
chying committed rL241202: Run teardown and setup before retry for expectedFlakey tests.
Run teardown and setup before retry for expectedFlakey tests
Jul 1 2015, 3:44 PM
chying closed D10830: Ignore teardown failure if it's caused by removing missing file or directory by committing rL241202: Run teardown and setup before retry for expectedFlakey tests.
Jul 1 2015, 3:44 PM

Jun 30 2015

chying updated the diff for D10830: Ignore teardown failure if it's caused by removing missing file or directory.

Based on feedback, handle teardown and setup inside of expectedFlakey function.
Don't run retry if the test case is already marked as xfail or skip.

Jun 30 2015, 3:52 PM

Jun 29 2015

chying retitled D10830: Ignore teardown failure if it's caused by removing missing file or directory from to Ignore teardown failure if it's caused by removing missing file or directory.
Jun 29 2015, 8:32 PM
chying committed rL241014: Revert "Mark test_sb_api_listener_event_process_state as flakey".
Revert "Mark test_sb_api_listener_event_process_state as flakey"
Jun 29 2015, 3:40 PM

Jun 25 2015

chying accepted D10721: Added expectedFlakey test decorator.
Jun 25 2015, 10:44 AM

Jun 4 2015

chying retitled D10252: Add android test to darwin builder from to Add android test to darwin builder.
Jun 4 2015, 12:34 PM

Jun 1 2015

chying committed rL238778: Increase timeout value for lldb test step to 1800 seconds.
Increase timeout value for lldb test step to 1800 seconds
Jun 1 2015, 2:06 PM
chying closed D10166: Increase timeout value for lldb test step to 1800 seconds by committing rL238778: Increase timeout value for lldb test step to 1800 seconds.
Jun 1 2015, 2:06 PM
chying retitled D10166: Increase timeout value for lldb test step to 1800 seconds from to Increase timeout value for lldb test step to 1800 seconds.
Jun 1 2015, 12:41 PM

May 29 2015

chying committed rL238613: Send email notification for failures on lldb android builder.
Send email notification for failures on lldb android builder
May 29 2015, 2:24 PM
chying closed D9953: Send email notification for failures on lldb android builder by committing rL238613: Send email notification for failures on lldb android builder.
May 29 2015, 2:24 PM
chying committed rL238595: Add '+' sign at the end of echo message for debugserver.
Add '+' sign at the end of echo message for debugserver
May 29 2015, 11:48 AM
chying closed D10133: Add '+' sign at the end of echo message for debugserver by committing rL238595: Add '+' sign at the end of echo message for debugserver.
May 29 2015, 11:48 AM
chying retitled D10133: Add '+' sign at the end of echo message for debugserver from to Add '+' sign at the end of echo message for debugserver.
May 29 2015, 11:21 AM

May 28 2015

chying committed rL238535: Add '+' sign at the end of echo package.
Add '+' sign at the end of echo package
May 28 2015, 6:06 PM
chying closed D10116: Add '+' sign at the end of echo package by committing rL238535: Add '+' sign at the end of echo package.
May 28 2015, 6:06 PM
chying retitled D10116: Add '+' sign at the end of echo package from to Add '+' sign at the end of echo package.
May 28 2015, 5:59 PM