Convert assertTrue(a == b) to assertEqual(a, b) to produce better failure messages.
These were mostly done via regex search & replace, with some manual fixes.
Paths
| Differential D95813
[lldb] Convert assertTrue(a == b) to assertEqual(a, b) ClosedPublic Authored by kastiglione on Feb 1 2021, 12:24 PM.
Details Summary Convert assertTrue(a == b) to assertEqual(a, b) to produce better failure messages. These were mostly done via regex search & replace, with some manual fixes.
Diff Detail
Event Timelinekastiglione created this revision. Comment Actions Cool, I was under the impression @teemperor had already done something similar, but I must be misremembering.
This revision is now accepted and ready to land.Feb 1 2021, 3:50 PM
Comment Actions
I ran one big regex that got most of the Equal/Less/Bigger than, but I think the multi-line calls I didn't transform (because of laziness). Comment Actions Don't see any change that looks wrong from scrolling over this, so LGTM
This revision was landed with ongoing or failed builds.Feb 2 2021, 12:39 PM Closed by commit rG619e2e095fb1: [lldb] Convert assertTrue(a == b) to assertEqual(a, b) (authored by kastiglione). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 320878 lldb/test/API/commands/register/register/register_command/TestRegisters.py
lldb/test/API/commands/watchpoints/watchpoint_events/TestWatchpointEvents.py
lldb/test/API/functionalities/breakpoint/breakpoint_conditions/TestBreakpointConditions.py
lldb/test/API/functionalities/breakpoint/breakpoint_ignore_count/TestBreakpointIgnoreCount.py
lldb/test/API/functionalities/breakpoint/breakpoint_in_delayslot/TestAvoidBreakpointInDelaySlot.py
lldb/test/API/functionalities/breakpoint/serialize/TestBreakpointSerialization.py
lldb/test/API/functionalities/conditional_break/TestConditionalBreak.py
lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/atomic/TestLibCxxAtomic.py
lldb/test/API/functionalities/data-formatter/data-formatter-synthval/TestDataFormatterSynthVal.py
lldb/test/API/functionalities/data-formatter/vector-types/TestVectorTypesFormatting.py
lldb/test/API/functionalities/exec/TestExec.py
lldb/test/API/functionalities/return-value/TestReturnValue.py
lldb/test/API/functionalities/tty/TestTerminal.py
lldb/test/API/functionalities/type_get_module/TestTypeGetModule.py
lldb/test/API/lang/c/bitfields/TestBitfields.py
lldb/test/API/lang/c/stepping/TestStepAndBreakpoints.py
lldb/test/API/lang/cpp/class_static/TestStaticVariables.py
lldb/test/API/lang/cpp/class_types/TestClassTypes.py
lldb/test/API/lang/cpp/dynamic-value/TestCppValueCast.py
lldb/test/API/lang/cpp/template/TestTemplateArgs.py
lldb/test/API/lang/objc/blocks/TestObjCIvarsInBlocks.py
lldb/test/API/lang/objc/foundation/TestObjCMethods.py
lldb/test/API/lang/objc/foundation/TestObjectDescriptionAPI.py
lldb/test/API/lang/objc/foundation/TestSymbolTable.py
lldb/test/API/lang/objc/objc-checker/TestObjCCheckers.py
lldb/test/API/lang/objc/objc-class-method/TestObjCClassMethod.py
lldb/test/API/python_api/disassemble-raw-data/TestDisassembleRawData.py
lldb/test/API/python_api/disassemble-raw-data/TestDisassemble_VST1_64.py
lldb/test/API/python_api/event/TestEvents.py
lldb/test/API/python_api/frame/TestFrames.py
lldb/test/API/python_api/frame/inlines/TestInlinedFrame.py
lldb/test/API/python_api/function_symbol/TestDisasmAPI.py
lldb/test/API/python_api/function_symbol/TestSymbolAPI.py
lldb/test/API/python_api/lldbutil/frame/TestFrameUtils.py
lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py
lldb/test/API/python_api/process/io/TestProcessIO.py
lldb/test/API/python_api/process/read-mem-cstring/TestReadMemCString.py
lldb/test/API/python_api/sbdata/TestSBData.py
lldb/test/API/python_api/symbol-context/TestSymbolContext.py
lldb/test/API/python_api/target/TestTargetAPI.py
lldb/test/API/python_api/thread/TestThreadAPI.py
lldb/test/API/python_api/type/TestTypeList.py
lldb/test/API/python_api/value/TestValueAPI.py
lldb/test/API/python_api/value/linked_list/TestValueAPILinkedList.py
lldb/test/API/python_api/watchpoint/TestSetWatchpoint.py
lldb/test/API/python_api/watchpoint/TestWatchpointIter.py
lldb/test/API/python_api/watchpoint/condition/TestWatchpointConditionAPI.py
lldb/test/API/python_api/watchpoint/watchlocation/TestSetWatchlocation.py
lldb/test/API/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py
lldb/test/API/terminal/TestSTTYBeforeAndAfter.py
lldb/test/API/tools/lldb-server/registers-target-xml-reading/TestGdbRemoteTargetXmlPacket.py
lldb/test/API/tools/lldb-vscode/breakpoint-events/TestVSCode_breakpointEvents.py
lldb/test/API/tools/lldb-vscode/console/TestVSCode_console.py
lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py
lldb/test/API/tools/lldb-vscode/variables/TestVSCode_variables.py
|
10/10