This is an archive of the discontinued LLVM Phabricator instance.

Differential D95746

clang: Exclude efi_main from -Wmissing-prototypes
ClosedPublic

Authored by DaanDeMeyer on Jan 30 2021, 11:31 AM.

Download Raw Diff

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rG7dd42ecfa2a2: clang: Exclude efi_main from -Wmissing-prototypes

Summary

When compiling UEFI applications, the main function is named
efi_main() instead of main(). Let's exclude efi_main() from
-Wmissing-prototypes as well to avoid warnings when working
on UEFI applications.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	290 ms	x64 debian > libarcher.races::task-dependency.c
	190 ms	x64 debian > libarcher.races::task-taskgroup-unrelated.c
	280 ms	x64 debian > libarcher.races::task-taskwait-nested.c
	330 ms	x64 debian > libarcher.races::task-two.c
	370 ms	x64 debian > libarcher.task::task-barrier.c
		View Full Test Results (13 Failed)

Event Timeline

DaanDeMeyer requested review of this revision.Jan 30 2021, 11:31 AM

DaanDeMeyer created this revision.

Herald added a subscriber: cfe-commits. · View Herald TranscriptJan 30 2021, 11:31 AM

Harbormaster completed remote builds in B87280: Diff 320318.Jan 30 2021, 12:21 PM

CI failures seem unrelated?

DaanDeMeyer updated this revision to Diff 320899.Feb 2 2021, 1:40 PM

Harbormaster completed remote builds in B87579: Diff 320899.Feb 2 2021, 2:18 PM

Please include test coverage

Added a test

Harbormaster completed remote builds in B89995: Diff 325114.Feb 19 2021, 5:28 PM

Looks good to me - maybe the test could be rolled into whatever file is already testing -Wmissing-prototype and the existing special case for "main"?

Do you need me to commit this, or can you commit it yourself?

This revision is now accepted and ready to land.Feb 19 2021, 7:33 PM

Moved the test into the no-warn-missing-prototype test as requested.

I should be able to commit it myself. Thanks for the review!

Reaffirming approval with the test change - looks great!

This revision was landed with ongoing or failed builds.Feb 20 2021, 12:04 PM

Closed by commit rG7dd42ecfa2a2: clang: Exclude efi_main from -Wmissing-prototypes (authored by DaanDeMeyer). · Explain Why

This revision was automatically updated to reflect the committed changes.

DaanDeMeyer added a commit: rG7dd42ecfa2a2: clang: Exclude efi_main from -Wmissing-prototypes.

Harbormaster completed remote builds in B90068: Diff 325224.Feb 20 2021, 12:38 PM

Revision Contents

Path

Size

clang/

lib/

Sema/

2 lines

Diff 320899

clang/lib/Sema/SemaDecl.cpp

This file is larger than 256 KB, so syntax highlighting is disabled by default.

	Show First 20 Lines • Show All 13,861 Lines • ▼ Show 20 Lines		ShouldWarnAboutMissingPrototype(const FunctionDecl *FD,

	// Don't warn about C++ member functions.			// Don't warn about C++ member functions.
	if (isa<CXXMethodDecl>(FD))			if (isa<CXXMethodDecl>(FD))
	return false;			return false;

	// Don't warn about 'main'.			// Don't warn about 'main'.
	if (isa<TranslationUnitDecl>(FD->getDeclContext()->getRedeclContext()))			if (isa<TranslationUnitDecl>(FD->getDeclContext()->getRedeclContext()))
	if (IdentifierInfo *II = FD->getIdentifier())			if (IdentifierInfo *II = FD->getIdentifier())
	if (II->isStr("main"))			if (II->isStr("main") \|\| II->isStr("efi_main"))
	return false;			return false;

	// Don't warn about inline functions.			// Don't warn about inline functions.
	if (FD->isInlined())			if (FD->isInlined())
	return false;			return false;

	// Don't warn about function templates.			// Don't warn about function templates.
	if (FD->getDescribedFunctionTemplate())			if (FD->getDescribedFunctionTemplate())
	▲ Show 20 Lines • Show All 4,530 Lines • Show Last 20 Lines