- User Since
- Oct 21 2018, 9:54 AM (258 w, 2 d)
Jan 2 2023
I have commit access and just pushed the commit to the main branch. Thanks for taking the time to review!
Added a few checks to the test and modified the python open() command to use a raw string to hopefully fix the test on Windows
Dec 20 2022
Updated summary and added a test. The test fails on the main branch and passes with the changes made in this diff.
Dec 19 2022
Here's the offending file:
This sounds like an argument saying the existing code is correct, no?
Nov 17 2021
Nov 16 2021
Addressed comments by adding two new errors, one for character literals and one for numeric literals.
Added some people that were recent reviewers of changes to this file and some clangd folks.
Feb 20 2021
I should be able to commit it myself. Thanks for the review!
Moved the test into the no-warn-missing-prototype test as requested.
Feb 19 2021
Added a test
Feb 2 2021
Jan 31 2021
CI failures seem unrelated?
Jan 30 2021
Dec 20 2020
Nov 18 2020
Abandoning as the end result is too slow even when including a limited number of files.
Nov 16 2020
Fix all the bugs after doing some proper testing.
Nov 15 2020
Switched from all or nothing command line option to per file config.
May 6 2020
I pushed the commit to github. Thanks for the help!
I should have commit access now. Is there any documentation on how exactly to do a merge? Do I just add the commit to master and push? I apologize if this seems obvious, I just want to make sure I'm not inadvertently breaking something.
May 5 2020
(I don't have commit access so it'd be great if someone could merge this for me, at least that's how my other contributions have been handled)
Apr 26 2020
- Moved docs to Format.h and re-generated rst file using dump_format_style.py
- Expanded comment with an explanation for why you might want to not have a space before the parens of a ForEach macro
Abandoning this since clangd shouldn't be forced to deal with the outrageous build system that I'm forced to use. I'm currently just building clangd from source with these changes which works fine.
Turns out this is already possible by disabling Cpp11BracedListStyle. The proposed change introduced too many changes regardless so I'm abandoning this.
Apr 25 2020
Mar 26 2020
Of course, if there's interest in adding this I'll fix all the tests but I wanted to make sure there was interest in adding this since it changes clang-format's behavior. Can you confirm that this change in behavior is a good thing and might be merged if I fix all the tests? If the existing output cannot be changed in any way then this revision can be closed since it fundamentally requires changing clang-format's output.
Mar 15 2020
New implementation that breaks fewer tests.
Changed the implementation to simply remove the handling of l_brace in tok::equal. The state machine simply continues executing and the next case will be the l_brace case which first tries to parse the l_brace as a braced init list.
Feb 26 2020
Is there CI infra that runs for each revision? I verified all the format unit tests still pass but I haven't run the entire test suite on my machine.
Feb 25 2020
I do not have commit access. It would be great if someone could merge this for me.
Added extra unit tests
Feb 24 2020
Added unit tests and fixed the case where stuff follows the do statement (like a comment).
Feb 23 2020
Jan 21 2020
Jan 20 2020
Oct 23 2018
You can commit them. Thanks for all the quick responses!
Update diff according to comments.
Oct 22 2018
Updated diff according to comments.