Page MenuHomePhabricator

[lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS
AbandonedPublic

Authored by Abpostelnicu on Jan 29 2021, 8:00 AM.

Details

Summary

Fix fallout caused by D89156 on 11.0.1 for MacOS

Diff Detail

Event Timeline

Abpostelnicu requested review of this revision.Jan 29 2021, 8:00 AM
Abpostelnicu created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 29 2021, 8:00 AM

Update with format

LGTM (and thanks for the fix and apologies for the break) )but I think @tstellar should have a look given it's fixing a build break in the release/11.x branch caused by my porting of changes from master for https://bugs.llvm.org/show_bug.cgi?id=48053

lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.h
58

D89156 pluralized the name (old_modules with an s) in all the places it made this change, since it's now a collection. IMO it would make sense to do the same in this change.

Update for plularization of variables name.

Abpostelnicu marked an inline comment as done.Jan 29 2021, 8:13 AM
Abpostelnicu added inline comments.
lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.h
58

Thanks, it makes sense to be pluralized.

Abpostelnicu marked an inline comment as done.Jan 30 2021, 1:29 AM

@tstellar what do you suggest to do here?

rebased on 11.1rc2

The failure is wrong.

Abpostelnicu abandoned this revision.Feb 12 2021, 1:26 AM

This has landed and trunk is already fixed.