Page MenuHomePhabricator

JosephTremoulet (Joseph Tremoulet)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 2 2015, 7:30 PM (277 w, 1 d)

Recent Activity

Today

JosephTremoulet committed rG4a55c98fa7be: [lldb] Normalize paths in new test (authored by JosephTremoulet).
[lldb] Normalize paths in new test
Wed, Sep 23, 12:42 PM
JosephTremoulet committed rG20f84257ac4a: [lldb] Fix GetRemoteSharedModule fallback logic (authored by JosephTremoulet).
[lldb] Fix GetRemoteSharedModule fallback logic
Wed, Sep 23, 6:01 AM
JosephTremoulet closed D88099: [lldb] Fix GetRemoteSharedModule fallback logic.
Wed, Sep 23, 6:01 AM · Restricted Project

Yesterday

JosephTremoulet added a reviewer for D88099: [lldb] Fix GetRemoteSharedModule fallback logic: jasonmolenda.
Tue, Sep 22, 7:29 AM · Restricted Project
JosephTremoulet requested review of D88099: [lldb] Fix GetRemoteSharedModule fallback logic.
Tue, Sep 22, 7:27 AM · Restricted Project

Mon, Aug 31

JosephTremoulet added a comment to D86863: [EarlyCSE] Verify hash code in regression tests.

Yeah, the potential for quadratic explosion is why I didn't hook this flag up to expensive checks when I added it. It occurs to me now that if we want, we could presumably have some cutoff counter so that after inserting 300 instructions or whatever limit is reasonable, we start hashing normally. We'd have to empty the table and repopulate it with the normal hash when we cut over, but that should be doable I think (it's similar to what the table does internally when it grows).

Mon, Aug 31, 11:07 AM · Restricted Project

Wed, Aug 26

JosephTremoulet added a comment to D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly.

To clarify, the failure did not reproduce for me in the SUSE 15.02 container. I don't know what I'm doing differently. To create the environment, I just did docker run ... opensuse/leap:15.2, and then zypper in gcc-c++ python3-devel inside the container.

Wed, Aug 26, 9:52 AM · Restricted Project
JosephTremoulet added a comment to D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly.

FWIW, I tried running the test in an SUSE 15.2 docker container (on an Ubuntu 18.04 host), and here's what I'm seeing. raise and abort indeed do not indicate that they had the S set in the augmentation:

Wed, Aug 26, 8:38 AM · Restricted Project
JosephTremoulet added a comment to D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly.

eh_frame augmented UnwindPlan:
...
This UnwindPlan is for a trap handler function: yes.

Wed, Aug 26, 7:53 AM · Restricted Project

Tue, Aug 25

JosephTremoulet added a comment to D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly.

And its parent 'raise' is set so as well because of 'GetNextFrame()->m_frame_type == eTrapHandlerFrame '.

Tue, Aug 25, 7:56 AM · Restricted Project

May 12 2020

JosephTremoulet added a reviewer for D79760: [WinEH64] Fix a crush issue when c++ exception nested in a particular form.: tentzen.
May 12 2020, 6:52 PM · Restricted Project

Feb 10 2020

JosephTremoulet accepted D74285: [EarlyCSE] avoid crashing when detecting min/max/abs patterns (PR41083).

LGTM, thanks.

Feb 10 2020, 2:06 PM · Restricted Project

Dec 4 2019

JosephTremoulet committed rG95b2e516bd3e: Change Target::FindBreakpointsByName to return Expected<vector> (authored by JosephTremoulet).
Change Target::FindBreakpointsByName to return Expected<vector>
Dec 4 2019, 7:03 AM
JosephTremoulet closed D70907: Change Target::FindBreakpointsByName to return Expected<vector>.
Dec 4 2019, 7:03 AM · Restricted Project

Dec 3 2019

JosephTremoulet added inline comments to D70907: Change Target::FindBreakpointsByName to return Expected<vector>.
Dec 3 2019, 9:37 AM · Restricted Project
JosephTremoulet updated the diff for D70907: Change Target::FindBreakpointsByName to return Expected<vector>.
  • Use invalid_argument error code
Dec 3 2019, 9:37 AM · Restricted Project
JosephTremoulet retitled D70907: Change Target::FindBreakpointsByName to return Expected<vector> from Change Target::FindBreakpointsByName to use a vector to Change Target::FindBreakpointsByName to return Expected<vector>.
Dec 3 2019, 8:14 AM · Restricted Project
JosephTremoulet updated the diff for D70907: Change Target::FindBreakpointsByName to return Expected<vector>.
  • Change signature to return Expected<vector<BreakpointSP>>
Dec 3 2019, 8:04 AM · Restricted Project

Dec 2 2019

JosephTremoulet added inline comments to D70907: Change Target::FindBreakpointsByName to return Expected<vector>.
Dec 2 2019, 10:26 AM · Restricted Project
JosephTremoulet added reviewers for D70907: Change Target::FindBreakpointsByName to return Expected<vector>: jingham, JDevlieghere.
Dec 2 2019, 8:05 AM · Restricted Project
JosephTremoulet created D70907: Change Target::FindBreakpointsByName to return Expected<vector>.
Dec 2 2019, 8:05 AM · Restricted Project

Oct 18 2019

JosephTremoulet committed rG77460d3888c5: ProcessMinidump: Suppress reporting stop for signal '0' (authored by JosephTremoulet).
ProcessMinidump: Suppress reporting stop for signal '0'
Oct 18 2019, 8:01 AM
JosephTremoulet committed rGd094d97d0223: LLDB: Use LLVM's type for minidump ExceptionStream [NFC] (authored by JosephTremoulet).
LLDB: Use LLVM's type for minidump ExceptionStream [NFC]
Oct 18 2019, 8:01 AM
JosephTremoulet closed D68096: ProcessMinidump: Suppress reporting stop for signal '0'.
Oct 18 2019, 8:01 AM · Restricted Project
JosephTremoulet committed rGa50272f8261f: Update MinidumpYAML to use minidump::Exception for exception stream (authored by JosephTremoulet).
Update MinidumpYAML to use minidump::Exception for exception stream
Oct 18 2019, 8:01 AM
JosephTremoulet closed D68658: LLDB: Use LLVM's type for minidump ExceptionStream [NFC].
Oct 18 2019, 8:01 AM · Restricted Project
JosephTremoulet closed D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
Oct 18 2019, 8:01 AM · Restricted Project, Restricted Project
JosephTremoulet committed rGe44524736c4a: Add ExceptionStream to llvm::Object::minidump (authored by JosephTremoulet).
Add ExceptionStream to llvm::Object::minidump
Oct 18 2019, 7:42 AM
JosephTremoulet closed D68656: Add ExceptionStream to llvm::Object::minidump.
Oct 18 2019, 7:42 AM · Restricted Project

Oct 17 2019

JosephTremoulet added inline comments to D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
Oct 17 2019, 10:33 AM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • Rebase
  • Use Twine instead of formatv
Oct 17 2019, 10:33 AM · Restricted Project, Restricted Project

Oct 16 2019

JosephTremoulet added inline comments to D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
Oct 16 2019, 4:39 AM · Restricted Project, Restricted Project

Oct 15 2019

JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • punctuation fixes
Oct 15 2019, 7:59 AM · Restricted Project, Restricted Project
JosephTremoulet added inline comments to D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
Oct 15 2019, 7:59 AM · Restricted Project, Restricted Project

Oct 14 2019

JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • Move test
Oct 14 2019, 7:19 AM · Restricted Project, Restricted Project
JosephTremoulet added inline comments to D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
Oct 14 2019, 7:01 AM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • Remove TODO, lit-ify negative test and tighten check
Oct 14 2019, 6:52 AM · Restricted Project, Restricted Project

Oct 13 2019

JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • ...and fix namespace...
Oct 13 2019, 6:23 PM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • Fix Expected<> types
Oct 13 2019, 6:14 PM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • Apply review feedback (-auto, -memset, +comments)
Oct 13 2019, 5:54 PM · Restricted Project, Restricted Project

Oct 11 2019

JosephTremoulet added a comment to D68096: ProcessMinidump: Suppress reporting stop for signal '0'.

If this patch is solely meant to fix this issue, then I remove my "Requires Changes" and this patch is good to go if it no longer hangs LLDB.

Oct 11 2019, 11:19 AM · Restricted Project
JosephTremoulet added a comment to D68096: ProcessMinidump: Suppress reporting stop for signal '0'.

Just to make sure I'm understanding the feedback correctly, I'll try to summarize. Please let me know if this is off track:

Oct 11 2019, 9:28 AM · Restricted Project
JosephTremoulet added a comment to D68657: Update MinidumpYAML to use minidump::Exception for exception stream.

Added Exception stream to minidump-basic.yaml as suggested.

Oct 11 2019, 9:01 AM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
Address review feedback
Oct 11 2019, 9:01 AM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D68656: Add ExceptionStream to llvm::Object::minidump.
  • Remove useless comment and leftover debugging cruft
Oct 11 2019, 7:55 AM · Restricted Project
JosephTremoulet added inline comments to D68656: Add ExceptionStream to llvm::Object::minidump.
Oct 11 2019, 7:55 AM · Restricted Project

Oct 10 2019

JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • Update test input yaml Exception stream
Oct 10 2019, 2:05 PM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D68096: ProcessMinidump: Suppress reporting stop for signal '0'.
  • Rebase
  • Add testcase
Oct 10 2019, 2:05 PM · Restricted Project
JosephTremoulet added a comment to D68657: Update MinidumpYAML to use minidump::Exception for exception stream.

Therefore I think it would make sense to just spell out each member of that array as a separate member in the yaml representation, which should be a much simpler endeavour. We can use the "actual parameter count" field to suppress the fields that don't contain any value, if they really are zero, which should make the yaml output concise in the usual cases. I think something like this should be sufficient:
...
I think that would strike a good balance between code complexity, output brevity, and being able to generate interesting and potentially invalid inputs for other tools (which is one of the main goals of yaml2obj, and so interpreting the input too strictly is not desired/helpful).

Oct 10 2019, 11:31 AM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • Add test with extraneous parameter
Oct 10 2019, 11:23 AM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • Change Exception Information format per feedback
Oct 10 2019, 11:12 AM · Restricted Project, Restricted Project
JosephTremoulet added a comment to D68656: Add ExceptionStream to llvm::Object::minidump.

Hmm.. maybe just keep those constants defined in lldb somewhere (e.g. right next to or inside the RefreshStateAfterStop function)? That's the place which does the decoding and also includes the OS switch, so it makes it easier to explain their purpose and why they are different for each OS...

Oct 10 2019, 8:31 AM · Restricted Project
JosephTremoulet retitled D68658: LLDB: Use LLVM's type for minidump ExceptionStream [NFC] from LLDB: Use LLVM's type for minidump ExceptionStream to LLDB: Use LLVM's type for minidump ExceptionStream [NFC].
Oct 10 2019, 8:31 AM · Restricted Project
JosephTremoulet updated the diff for D68658: LLDB: Use LLVM's type for minidump ExceptionStream [NFC].
  • Define DumpRequested constant in-line, per feedback in D68656
Oct 10 2019, 8:31 AM · Restricted Project
JosephTremoulet updated the diff for D68656: Add ExceptionStream to llvm::Object::minidump.
  • Remove ExceptionCode enumeration
Oct 10 2019, 8:31 AM · Restricted Project
JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.

rebase

Oct 10 2019, 8:31 AM · Restricted Project, Restricted Project

Oct 9 2019

JosephTremoulet updated the diff for D68656: Add ExceptionStream to llvm::Object::minidump.
  • Remove the os-defined exception code enum values
Oct 9 2019, 8:49 PM · Restricted Project
JosephTremoulet added a comment to D68656: Add ExceptionStream to llvm::Object::minidump.

Thanks for taking your time to do this. I have one question: It looks like you're not using the exception code enum in the follow-up patch. I think that's completely reasonable given that the enum values are overloaded and system-dependent. But given this fact, and the fact that I am not convinced the enum values are completely right (e.g. the linux signal numbers depend also on the architecture -- though this may not manifest itself on the architectures that breakpad supports right now), what would you say to just dropping that enumeration?

Oct 9 2019, 8:49 PM · Restricted Project

Oct 8 2019

JosephTremoulet added reviewers for D68657: Update MinidumpYAML to use minidump::Exception for exception stream: labath, jhenderson, clayborg.
Oct 8 2019, 12:03 PM · Restricted Project, Restricted Project
JosephTremoulet added reviewers for D68658: LLDB: Use LLVM's type for minidump ExceptionStream [NFC]: labath, clayborg.
Oct 8 2019, 12:03 PM · Restricted Project
JosephTremoulet added reviewers for D68656: Add ExceptionStream to llvm::Object::minidump: labath, jhenderson, clayborg.
Oct 8 2019, 12:03 PM · Restricted Project
JosephTremoulet created D68658: LLDB: Use LLVM's type for minidump ExceptionStream [NFC].
Oct 8 2019, 12:03 PM · Restricted Project
JosephTremoulet created D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
Oct 8 2019, 11:53 AM · Restricted Project, Restricted Project
JosephTremoulet created D68656: Add ExceptionStream to llvm::Object::minidump.
Oct 8 2019, 11:53 AM · Restricted Project
JosephTremoulet added a comment to D68645: MinidumpYAML: Add support for the memory info list stream.

Nit: Title says "thread" rather than "memory info"

Oct 8 2019, 7:57 AM · Restricted Project

Sep 30 2019

JosephTremoulet added a comment to D68096: ProcessMinidump: Suppress reporting stop for signal '0'.

It doesn't look like it should be too hard to add yaml support for the exceptions stream -- it should only be a matter of adapting the patterns already used for other stream to work for this particular case. Could you give a go at that?

Sep 30 2019, 9:01 AM · Restricted Project
JosephTremoulet retitled D68096: ProcessMinidump: Suppress reporting stop for signal '0' from ProcessMinidump: inject SIGSTOP on Linux if no thread has a signal to ProcessMinidump: Suppress reporting stop for signal '0'.
Sep 30 2019, 8:56 AM · Restricted Project
JosephTremoulet updated the diff for D68096: ProcessMinidump: Suppress reporting stop for signal '0'.
  • Review feedback
Sep 30 2019, 8:51 AM · Restricted Project

Sep 27 2019

JosephTremoulet updated the diff for D68096: ProcessMinidump: Suppress reporting stop for signal '0'.
  • Use accessor for m_unix_signals_sp
Sep 27 2019, 12:09 PM · Restricted Project
JosephTremoulet added inline comments to D68096: ProcessMinidump: Suppress reporting stop for signal '0'.
Sep 27 2019, 12:09 PM · Restricted Project
JosephTremoulet retitled D68096: ProcessMinidump: Suppress reporting stop for signal '0' from Add Linux signal support to ProcessMinidump to ProcessMinidump: inject SIGSTOP on Linux if no thread has a signal.
Sep 27 2019, 11:57 AM · Restricted Project
JosephTremoulet updated the diff for D68096: ProcessMinidump: Suppress reporting stop for signal '0'.
  • Move artificial SIGSTOP injection to RefreshStateAfterStop
Sep 27 2019, 11:55 AM · Restricted Project
JosephTremoulet added a comment to D68096: ProcessMinidump: Suppress reporting stop for signal '0'.

Fortunately, for the functionality you're testing, I don't think you really need the executable file, so you can just ignore the elf bit and test with a plain lldb -c foo.dmp (obviously, you won't get the backtrace that way, but you don't really need that here.

Sep 27 2019, 8:47 AM · Restricted Project

Sep 26 2019

JosephTremoulet added reviewers for D68096: ProcessMinidump: Suppress reporting stop for signal '0': labath, clayborg.
Sep 26 2019, 12:28 PM · Restricted Project
JosephTremoulet added a comment to D68096: ProcessMinidump: Suppress reporting stop for signal '0'.

I'm trying to fix an issue where opening a minidump created by breakpad in lldb just hangs, but if I use breakpad's minidump-2-core on that same dump then opening the core dump works fine. From debugging the two cases I can see that the critical logic that ProcessElfCore has which ProcessMinidump lacks is here, and the code in this patch is my attempt to replicate that.

Sep 26 2019, 12:28 PM · Restricted Project
JosephTremoulet created D68096: ProcessMinidump: Suppress reporting stop for signal '0'.
Sep 26 2019, 12:10 PM · Restricted Project

Aug 7 2019

JosephTremoulet added inline comments to D64993: Fix PC adjustment in StackFrame::GetSymbolContext.
Aug 7 2019, 12:58 PM · Restricted Project, Restricted Project

Aug 6 2019

JosephTremoulet added a comment to D65815: [EarlyCSE] Add support for unary FNeg to EarlyCSE.

LGTM. Probably good to have someone else weigh in before committing (I touched this code last, but only to fix a couple bugs).

Aug 6 2019, 7:57 PM · Restricted Project
JosephTremoulet added inline comments to D65815: [EarlyCSE] Add support for unary FNeg to EarlyCSE.
Aug 6 2019, 2:23 PM · Restricted Project

Aug 2 2019

JosephTremoulet added a comment to D64993: Fix PC adjustment in StackFrame::GetSymbolContext.

Hey Joseph,

The test trap_frame_sym_ctx is failing on GreenDragon. Can you please have a look?

http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/32449/testReport/junit/LLDB/Unwind/trap_frame_sym_ctx_test/

Aug 2 2019, 12:07 PM · Restricted Project, Restricted Project
JosephTremoulet committed rG98264863254d: Use rip-relative addressing in asm test (authored by JosephTremoulet).
Use rip-relative addressing in asm test
Aug 2 2019, 12:06 PM
JosephTremoulet committed rG31e6dbe1c6a6: Fix PC adjustment in StackFrame::GetSymbolContext (authored by JosephTremoulet).
Fix PC adjustment in StackFrame::GetSymbolContext
Aug 2 2019, 9:57 AM
JosephTremoulet updated the diff for D64993: Fix PC adjustment in StackFrame::GetSymbolContext.
  • Expand comment about return trampolines
  • rename PropagateTrapHandlerFlag -> PropagateTrapHandlerFlagFromUnwindPlan
Aug 2 2019, 9:43 AM · Restricted Project, Restricted Project

Jul 31 2019

JosephTremoulet added a comment to D64993: Fix PC adjustment in StackFrame::GetSymbolContext.

I haven't looked at the implementation, but I did run into the problem you are fixing in the past, and I am happy that someone is finally implementing this. I just wanted to say that for testing, I think you should be able to create some hand-written assembly that creates the kind of stack frames and unwind info you need to trigger this. You can look at existing tests in lldb/lit/Unwind for examples.

Jul 31 2019, 12:46 PM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D64993: Fix PC adjustment in StackFrame::GetSymbolContext.
  • add test
Jul 31 2019, 12:43 PM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D64993: Fix PC adjustment in StackFrame::GetSymbolContext.
  • Move resolution helper from RegisterContextLLDB to lldb_private::Address
  • Defensively initialize out arguments
Jul 31 2019, 10:07 AM · Restricted Project, Restricted Project
JosephTremoulet added inline comments to D64993: Fix PC adjustment in StackFrame::GetSymbolContext.
Jul 31 2019, 8:52 AM · Restricted Project, Restricted Project

Jul 30 2019

JosephTremoulet added a comment to D64993: Fix PC adjustment in StackFrame::GetSymbolContext.

@jasonmolenda @clayborg ping. To clarify, the issue this fixes is, using test functionalities/signal/handle-abrt as an example:

#include <signal.h>
#include <stdio.h>
#include <stdlib.h>
Jul 30 2019, 6:27 PM · Restricted Project, Restricted Project

Jul 21 2019

JosephTremoulet added a comment to D63667: Support __kernel_rt_sigreturn in frame initialization.

You did not have DWARF for glibc installed: dnf debuginfo-install glibc

Then in fact your test was better as only real frames matter for this patch. There is some LLDB bug/incompatibility decoding inline function from (GCC-produced) DWARF but that is unrelated to this patch.

Jul 21 2019, 8:06 AM · Restricted Project, Restricted Project

Jul 19 2019

JosephTremoulet added inline comments to D64993: Fix PC adjustment in StackFrame::GetSymbolContext.
Jul 19 2019, 7:42 AM · Restricted Project, Restricted Project
JosephTremoulet created D64993: Fix PC adjustment in StackFrame::GetSymbolContext.
Jul 19 2019, 7:28 AM · Restricted Project, Restricted Project
JosephTremoulet committed rG3fd917d8860e: Support Linux signal return trampolines in frame initialization (authored by JosephTremoulet).
Support Linux signal return trampolines in frame initialization
Jul 19 2019, 7:10 AM

Jul 18 2019

JosephTremoulet added inline comments to D64894: [CMake] Don't set Python_ADDITIONAL_VERSIONS.
Jul 18 2019, 7:53 AM · Restricted Project, Restricted Project

Jul 15 2019

JosephTremoulet added a comment to D63667: Support __kernel_rt_sigreturn in frame initialization.

I'm guessing on this Linux system, you've got a trap receiver function on the stack that is on its first instruction or something? So backing up the pc value for *that* frame is the problem you're solving.
...
Just just to check, we've got a backtrace like...

Jul 15 2019, 8:11 PM · Restricted Project, Restricted Project
JosephTremoulet updated subscribers of D63667: Support __kernel_rt_sigreturn in frame initialization.

ping @jasonmolenda -- do the updates look like what you had in mind when you said " It'd be a good change to capture that information from the eh_frame though, even if we don't see a clear way to use it right now"?

Jul 15 2019, 2:29 PM · Restricted Project, Restricted Project
JosephTremoulet added a comment to D63667: Support __kernel_rt_sigreturn in frame initialization.

That LLDB frame #5 is a bit bogus

Jul 15 2019, 2:03 PM · Restricted Project, Restricted Project

Jun 27 2019

JosephTremoulet added a comment to D63667: Support __kernel_rt_sigreturn in frame initialization.

Shouldn't you add also symbol __restore_rt (Fedora 30 x86_64)?

Jun 27 2019, 2:00 PM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D63667: Support __kernel_rt_sigreturn in frame initialization.
  • Include __restore_rt
Jun 27 2019, 1:58 PM · Restricted Project, Restricted Project

Jun 25 2019

JosephTremoulet updated the diff for D63667: Support __kernel_rt_sigreturn in frame initialization.
  • fix copy pasta
Jun 25 2019, 1:06 PM · Restricted Project, Restricted Project
JosephTremoulet added a comment to D63667: Support __kernel_rt_sigreturn in frame initialization.

I've updated this with code to recognize the 'S' in the eh_frame augmentation and record it in a new bool member of UnwindPlan, m_plan_is_for_signal_trap. I haven't hooked up any consumers of the new bit; as you say, with the current code flow we don't parse the eh_frame info until after we've decided whether the current frame is a trap handler frame or not.

Jun 25 2019, 12:56 PM · Restricted Project, Restricted Project