Page MenuHomePhabricator

JosephTremoulet (Joseph Tremoulet)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 2 2015, 7:30 PM (220 w, 4 d)

Recent Activity

Wed, Aug 7

JosephTremoulet added inline comments to D64993: Fix PC adjustment in StackFrame::GetSymbolContext.
Wed, Aug 7, 12:58 PM · Restricted Project, Restricted Project

Tue, Aug 6

JosephTremoulet added a comment to D65815: [EarlyCSE] Add support for unary FNeg to EarlyCSE.

LGTM. Probably good to have someone else weigh in before committing (I touched this code last, but only to fix a couple bugs).

Tue, Aug 6, 7:57 PM · Restricted Project
JosephTremoulet added inline comments to D65815: [EarlyCSE] Add support for unary FNeg to EarlyCSE.
Tue, Aug 6, 2:23 PM · Restricted Project

Fri, Aug 2

JosephTremoulet added a comment to D64993: Fix PC adjustment in StackFrame::GetSymbolContext.

Hey Joseph,

The test trap_frame_sym_ctx is failing on GreenDragon. Can you please have a look?

http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/32449/testReport/junit/LLDB/Unwind/trap_frame_sym_ctx_test/

Fri, Aug 2, 12:07 PM · Restricted Project, Restricted Project
JosephTremoulet committed rG98264863254d: Use rip-relative addressing in asm test (authored by JosephTremoulet).
Use rip-relative addressing in asm test
Fri, Aug 2, 12:06 PM
JosephTremoulet committed rG31e6dbe1c6a6: Fix PC adjustment in StackFrame::GetSymbolContext (authored by JosephTremoulet).
Fix PC adjustment in StackFrame::GetSymbolContext
Fri, Aug 2, 9:57 AM
JosephTremoulet updated the diff for D64993: Fix PC adjustment in StackFrame::GetSymbolContext.
  • Expand comment about return trampolines
  • rename PropagateTrapHandlerFlag -> PropagateTrapHandlerFlagFromUnwindPlan
Fri, Aug 2, 9:43 AM · Restricted Project, Restricted Project

Wed, Jul 31

JosephTremoulet added a comment to D64993: Fix PC adjustment in StackFrame::GetSymbolContext.

I haven't looked at the implementation, but I did run into the problem you are fixing in the past, and I am happy that someone is finally implementing this. I just wanted to say that for testing, I think you should be able to create some hand-written assembly that creates the kind of stack frames and unwind info you need to trigger this. You can look at existing tests in lldb/lit/Unwind for examples.

Wed, Jul 31, 12:46 PM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D64993: Fix PC adjustment in StackFrame::GetSymbolContext.
  • add test
Wed, Jul 31, 12:43 PM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D64993: Fix PC adjustment in StackFrame::GetSymbolContext.
  • Move resolution helper from RegisterContextLLDB to lldb_private::Address
  • Defensively initialize out arguments
Wed, Jul 31, 10:07 AM · Restricted Project, Restricted Project
JosephTremoulet added inline comments to D64993: Fix PC adjustment in StackFrame::GetSymbolContext.
Wed, Jul 31, 8:52 AM · Restricted Project, Restricted Project

Tue, Jul 30

JosephTremoulet added a comment to D64993: Fix PC adjustment in StackFrame::GetSymbolContext.

@jasonmolenda @clayborg ping. To clarify, the issue this fixes is, using test functionalities/signal/handle-abrt as an example:

#include <signal.h>
#include <stdio.h>
#include <stdlib.h>
Tue, Jul 30, 6:27 PM · Restricted Project, Restricted Project

Jul 21 2019

JosephTremoulet added a comment to D63667: Support __kernel_rt_sigreturn in frame initialization.

You did not have DWARF for glibc installed: dnf debuginfo-install glibc

Then in fact your test was better as only real frames matter for this patch. There is some LLDB bug/incompatibility decoding inline function from (GCC-produced) DWARF but that is unrelated to this patch.

Jul 21 2019, 8:06 AM · Restricted Project, Restricted Project

Jul 19 2019

JosephTremoulet added inline comments to D64993: Fix PC adjustment in StackFrame::GetSymbolContext.
Jul 19 2019, 7:42 AM · Restricted Project, Restricted Project
JosephTremoulet created D64993: Fix PC adjustment in StackFrame::GetSymbolContext.
Jul 19 2019, 7:28 AM · Restricted Project, Restricted Project
JosephTremoulet committed rG3fd917d8860e: Support Linux signal return trampolines in frame initialization (authored by JosephTremoulet).
Support Linux signal return trampolines in frame initialization
Jul 19 2019, 7:10 AM

Jul 18 2019

JosephTremoulet added inline comments to D64894: [CMake] Don't set Python_ADDITIONAL_VERSIONS.
Jul 18 2019, 7:53 AM · Restricted Project, Restricted Project

Jul 15 2019

JosephTremoulet added a comment to D63667: Support __kernel_rt_sigreturn in frame initialization.

I'm guessing on this Linux system, you've got a trap receiver function on the stack that is on its first instruction or something? So backing up the pc value for *that* frame is the problem you're solving.
...
Just just to check, we've got a backtrace like...

Jul 15 2019, 8:11 PM · Restricted Project, Restricted Project
JosephTremoulet updated subscribers of D63667: Support __kernel_rt_sigreturn in frame initialization.

ping @jasonmolenda -- do the updates look like what you had in mind when you said " It'd be a good change to capture that information from the eh_frame though, even if we don't see a clear way to use it right now"?

Jul 15 2019, 2:29 PM · Restricted Project, Restricted Project
JosephTremoulet added a comment to D63667: Support __kernel_rt_sigreturn in frame initialization.

That LLDB frame #5 is a bit bogus

Jul 15 2019, 2:03 PM · Restricted Project, Restricted Project

Jun 27 2019

JosephTremoulet added a comment to D63667: Support __kernel_rt_sigreturn in frame initialization.

Shouldn't you add also symbol __restore_rt (Fedora 30 x86_64)?

Jun 27 2019, 2:00 PM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D63667: Support __kernel_rt_sigreturn in frame initialization.
  • Include __restore_rt
Jun 27 2019, 1:58 PM · Restricted Project, Restricted Project

Jun 25 2019

JosephTremoulet updated the diff for D63667: Support __kernel_rt_sigreturn in frame initialization.
  • fix copy pasta
Jun 25 2019, 1:06 PM · Restricted Project, Restricted Project
JosephTremoulet added a comment to D63667: Support __kernel_rt_sigreturn in frame initialization.

I've updated this with code to recognize the 'S' in the eh_frame augmentation and record it in a new bool member of UnwindPlan, m_plan_is_for_signal_trap. I haven't hooked up any consumers of the new bit; as you say, with the current code flow we don't parse the eh_frame info until after we've decided whether the current frame is a trap handler frame or not.

Jun 25 2019, 12:56 PM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D63667: Support __kernel_rt_sigreturn in frame initialization.
  • Fix typos
  • Convey 'S' eh_frame augmentation to UnwindPlan
Jun 25 2019, 12:35 PM · Restricted Project, Restricted Project

Jun 21 2019

JosephTremoulet added a comment to D63667: Support __kernel_rt_sigreturn in frame initialization.

FYI, I sent mail about this to lldb-dev.. I'll copy the contents here for the benefit of anybody who didn't see it there but could use the context:

Jun 21 2019, 1:55 PM · Restricted Project, Restricted Project
JosephTremoulet created D63667: Support __kernel_rt_sigreturn in frame initialization.
Jun 21 2019, 1:23 PM · Restricted Project, Restricted Project

Jun 17 2019

JosephTremoulet committed rGdaa1ae614295: [EarlyCSE] Fix hashing of self-compares (authored by JosephTremoulet).
[EarlyCSE] Fix hashing of self-compares
Jun 17 2019, 12:10 PM

Jun 14 2019

JosephTremoulet added inline comments to D63349: [EarlyCSE] Fix hashing of self-compares.
Jun 14 2019, 12:31 PM · Restricted Project
JosephTremoulet added inline comments to D63349: [EarlyCSE] Fix hashing of self-compares.
Jun 14 2019, 12:29 PM · Restricted Project
JosephTremoulet added inline comments to D63349: [EarlyCSE] Fix hashing of self-compares.
Jun 14 2019, 11:55 AM · Restricted Project
JosephTremoulet created D63349: [EarlyCSE] Fix hashing of self-compares.
Jun 14 2019, 11:18 AM · Restricted Project
JosephTremoulet added a comment to D62644: [EarlyCSE] Ensure equal keys have the same hash value.

It looks like this patch may have caused https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=15236. It would be great if you could have a look.

That assertion is also seen here:

https://bugs.llvm.org/show_bug.cgi?id=42280

However, as I wrote in that PR, with older opt versions it still crashes now and then, only that it often takes more attempts.
And then we hit a different assertion:

opt: ../include/llvm/ADT/DenseMap.h:404: void llvm::DenseMapBase<llvm::DenseMap<(anonymous namespace)::SimpleValue, llvm::ScopedHashTableVal<(anonymous namespace)::SimpleValue, llvm::Value *> *, llvm::DenseMapInfo<(anonymous namespace)::SimpleValue>, llvm::detail::DenseMapPair<(anonymous namespace)::SimpleValue, llvm::ScopedHashTableVal<(anonymous namespace)::SimpleValue, llvm::Value *> *> >, (anonymous namespace)::SimpleValue, llvm::ScopedHashTableVal<(anonymous namespace)::SimpleValue, llvm::Value *> *, llvm::DenseMapInfo<(anonymous namespace)::SimpleValue>, llvm::detail::DenseMapPair<(anonymous namespace)::SimpleValue, llvm::ScopedHashTableVal<(anonymous namespace)::SimpleValue, llvm::Value *> *> >::moveFromOldBuckets(BucketT *, BucketT *) [DerivedT = llvm::DenseMap<(anonymous namespace)::SimpleValue, llvm::ScopedHashTableVal<(anonymous namespace)::SimpleValue, llvm::Value *> *, llvm::DenseMapInfo<(anonymous namespace)::SimpleValue>, llvm::detail::DenseMapPair<(anonymous namespace)::SimpleValue, llvm::ScopedHashTableVal<(anonymous namespace)::SimpleValue, llvm::Value *> *> >, KeyT = (anonymous namespace)::SimpleValue, ValueT = llvm::ScopedHashTableVal<(anonymous namespace)::SimpleValue, llvm::Value *> *, KeyInfoT = llvm::DenseMapInfo<(anonymous namespace)::SimpleValue>, BucketT = llvm::detail::DenseMapPair<(anonymous namespace)::SimpleValue, llvm::ScopedHashTableVal<(anonymous namespace)::SimpleValue, llvm::Value *> *>]: Assertion `!FoundVal && "Key already in new map?"' failed.
Jun 14 2019, 7:01 AM · Restricted Project

Jun 13 2019

JosephTremoulet committed rG3bc6e2a7aa38: [EarlyCSE] Ensure equal keys have the same hash value (authored by JosephTremoulet).
[EarlyCSE] Ensure equal keys have the same hash value
Jun 13 2019, 8:22 AM

Jun 11 2019

JosephTremoulet updated the diff for D62644: [EarlyCSE] Ensure equal keys have the same hash value.
  • Remove useless assignment
Jun 11 2019, 12:12 PM · Restricted Project
JosephTremoulet added inline comments to D62644: [EarlyCSE] Ensure equal keys have the same hash value.
Jun 11 2019, 10:47 AM · Restricted Project
JosephTremoulet added inline comments to D62644: [EarlyCSE] Ensure equal keys have the same hash value.
Jun 11 2019, 7:43 AM · Restricted Project
JosephTremoulet updated the diff for D62644: [EarlyCSE] Ensure equal keys have the same hash value.
  • Add -earlycse-debug-hash flag, shorten new test
Jun 11 2019, 7:39 AM · Restricted Project

Jun 6 2019

JosephTremoulet added inline comments to D62644: [EarlyCSE] Ensure equal keys have the same hash value.
Jun 6 2019, 8:37 PM · Restricted Project
JosephTremoulet added inline comments to D62644: [EarlyCSE] Ensure equal keys have the same hash value.
Jun 6 2019, 1:20 PM · Restricted Project

Jun 5 2019

JosephTremoulet committed rGacb56090639d: [EarlyCSE] Add tests for negated min/max/abs [NFC] (authored by JosephTremoulet).
[EarlyCSE] Add tests for negated min/max/abs [NFC]
Jun 5 2019, 2:28 PM
JosephTremoulet updated the diff for D62644: [EarlyCSE] Ensure equal keys have the same hash value.

Fix style, rebase on top of test change

Jun 5 2019, 10:25 AM · Restricted Project
JosephTremoulet added a parent revision for D62644: [EarlyCSE] Ensure equal keys have the same hash value: D62918: [EarlyCSE] Add tests for negated min/max/abs [NFC].
Jun 5 2019, 10:25 AM · Restricted Project
JosephTremoulet added a child revision for D62918: [EarlyCSE] Add tests for negated min/max/abs [NFC]: D62644: [EarlyCSE] Ensure equal keys have the same hash value.
Jun 5 2019, 10:25 AM · Restricted Project
JosephTremoulet updated the summary of D62918: [EarlyCSE] Add tests for negated min/max/abs [NFC].
Jun 5 2019, 10:13 AM · Restricted Project
JosephTremoulet created D62918: [EarlyCSE] Add tests for negated min/max/abs [NFC].
Jun 5 2019, 10:13 AM · Restricted Project
JosephTremoulet added inline comments to D62644: [EarlyCSE] Ensure equal keys have the same hash value.
Jun 5 2019, 8:59 AM · Restricted Project

May 29 2019

JosephTremoulet created D62644: [EarlyCSE] Ensure equal keys have the same hash value.
May 29 2019, 9:39 PM · Restricted Project

Apr 24 2019

JosephTremoulet committed rG25c6a5073dfc: [lldb] Use local definition of get_cpuid_count (authored by JosephTremoulet).
[lldb] Use local definition of get_cpuid_count
Apr 24 2019, 11:01 AM
JosephTremoulet added a comment to D61036: [lldb] Use local definition of get_cpuid_count.

Switched to static function, and yes I do have commit access. Thanks for the review!

Apr 24 2019, 8:31 AM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D61036: [lldb] Use local definition of get_cpuid_count.
  • Use static function rather than anonymous namespace
Apr 24 2019, 8:30 AM · Restricted Project, Restricted Project

Apr 23 2019

JosephTremoulet added a comment to D61036: [lldb] Use local definition of get_cpuid_count.

@labath, as discussed in D59991, I went with a local copy of the function since I didn't see an obvious opportunity to tweak the calling code, but maybe I overlooked something. My copy of cpuid.h matches https://github.com/gcc-mirror/gcc/blob/gcc-5-branch/gcc/config/i386/cpuid.h

Apr 23 2019, 1:23 PM · Restricted Project, Restricted Project
JosephTremoulet added a reviewer for D61036: [lldb] Use local definition of get_cpuid_count: labath.
Apr 23 2019, 1:21 PM · Restricted Project, Restricted Project
JosephTremoulet created D61036: [lldb] Use local definition of get_cpuid_count.
Apr 23 2019, 1:18 PM · Restricted Project, Restricted Project
JosephTremoulet added a comment to D59991: [Linux/x86] Fix writing of non-gpr registers on newer processors.

gcc-5.4 technically supported, so we can try to make things work for you. I'd be best if you can create a patch that will make things work for you (since it's kinda hard for me to test that). Or at least, can you paste the contents of your cpuid.h somewhere?

Apr 23 2019, 9:06 AM · Restricted Project
JosephTremoulet added inline comments to D59991: [Linux/x86] Fix writing of non-gpr registers on newer processors.
Apr 23 2019, 8:42 AM · Restricted Project

Apr 4 2019

JosephTremoulet committed rG9f598ac7062c: [COFF] Fix delay import directory iterator (authored by JosephTremoulet).
[COFF] Fix delay import directory iterator
Apr 4 2019, 7:12 AM
JosephTremoulet added a comment to D60081: [COFF] Fix delay import directory iterator.

Thanks for the review!

Apr 4 2019, 7:12 AM · Restricted Project

Apr 3 2019

JosephTremoulet added a comment to D60081: [COFF] Fix delay import directory iterator.

Updated.

Apr 3 2019, 6:11 PM · Restricted Project
JosephTremoulet updated the diff for D60081: [COFF] Fix delay import directory iterator.
  • Merge exe yaml with test file, remove more cruft
Apr 3 2019, 6:10 PM · Restricted Project
JosephTremoulet updated the diff for D60081: [COFF] Fix delay import directory iterator.
  • Address review feedback
Apr 3 2019, 5:50 PM · Restricted Project
JosephTremoulet added a comment to D60081: [COFF] Fix delay import directory iterator.

Names normalized, cruft removed, thanks for the feedback.

Apr 3 2019, 5:50 PM · Restricted Project
JosephTremoulet added a comment to D60081: [COFF] Fix delay import directory iterator.

No, I hadn't seen the test files in lld/test/COFF; thanks for the pointers! Testcase added; I verified that it fails without the fix and passes without it, and that neither make check nor make check-lld regress.

Apr 3 2019, 11:17 AM · Restricted Project
JosephTremoulet updated the diff for D60081: [COFF] Fix delay import directory iterator.
  • add testcase
Apr 3 2019, 11:13 AM · Restricted Project

Apr 2 2019

JosephTremoulet committed rGfb4d9f7287c2: [SimplifyCFG] Don't split musttail call from ret (authored by JosephTremoulet).
[SimplifyCFG] Don't split musttail call from ret
Apr 2 2019, 8:49 AM
JosephTremoulet committed rGb69afa8e9ba5: [PruneEH] Don't split musttail call from ret (authored by JosephTremoulet).
[PruneEH] Don't split musttail call from ret
Apr 2 2019, 8:46 AM
JosephTremoulet added a comment to D60081: [COFF] Fix delay import directory iterator.

Can you tell me how to reproduce the issue? Maybe that's a good start to think about how to write a test.

Apr 2 2019, 8:08 AM · Restricted Project

Apr 1 2019

JosephTremoulet added a comment to D60081: [COFF] Fix delay import directory iterator.

I'm not sure how to update the tests for this change. Ideally I'd change test/tools/llvm-readobj/imports.test to use an input that has multiple delay-load DLL references. The inputs for that are (binary) coff files test/tools/llvm-readobj/Inputs/imports.exe.coff-x86-64 and test/tools/llvm-readobj/Inputs/imports.exe.coff-i386. @ruiu , do we have sources for those binaries checked in or otherwise available somewhere? Should I just generate new ones with similar import lists?

Apr 1 2019, 11:13 AM · Restricted Project
JosephTremoulet created D60081: [COFF] Fix delay import directory iterator.
Apr 1 2019, 11:13 AM · Restricted Project
JosephTremoulet added a reviewer for D60081: [COFF] Fix delay import directory iterator: ruiu.
Apr 1 2019, 11:13 AM · Restricted Project
JosephTremoulet created D60080: [SimplifyCFG] Don't split musttail call from ret.
Apr 1 2019, 11:10 AM · Restricted Project
JosephTremoulet added reviewers for D60080: [SimplifyCFG] Don't split musttail call from ret: fedor.sergeev, majnemer.
Apr 1 2019, 11:10 AM · Restricted Project
JosephTremoulet added reviewers for D60079: [PruneEH] Don't split musttail call from ret: fedor.sergeev, majnemer.
Apr 1 2019, 11:07 AM · Restricted Project
JosephTremoulet created D60079: [PruneEH] Don't split musttail call from ret.
Apr 1 2019, 11:06 AM · Restricted Project

Nov 29 2018

JosephTremoulet created D55077: [Mem2Reg] Fix nondeterministic corner case.
Nov 29 2018, 1:58 PM

Nov 28 2018

JosephTremoulet created D55027: [CallSiteSplitting] Report edge deletion to DomTreeUpdater.
Nov 28 2018, 2:06 PM

Nov 21 2018

JosephTremoulet added a comment to D54729: [Docs] Documentation for the saturation addition and subtraction intrinsics.

Thanks!

Nov 21 2018, 8:05 AM

Oct 25 2018

JosephTremoulet added a comment to D53053: [Intrinsic] Signed Saturation Addition Intrinsic.

I don't see this or its unsigned counterpart added to the LangRef; is that intentional, or an oversight?

Oct 25 2018, 1:21 PM

Jun 14 2018

JosephTremoulet abandoned D16238: Preliminary: enable "spill on exception path" and "spill on normal path" RS4GC options.
Jun 14 2018, 1:18 PM
JosephTremoulet added reviewers for D48192: [InstCombine] Avoid iteration/mutation conflict: majnemer, davide.
Jun 14 2018, 1:14 PM
JosephTremoulet created D48192: [InstCombine] Avoid iteration/mutation conflict.
Jun 14 2018, 1:12 PM

Nov 3 2016

JosephTremoulet added a comment to D26270: Avoid tail recursion elimination across calls with operand bundles.

I don't think funclets need to worry about this.

Nov 3 2016, 6:01 AM

Sep 3 2016

JosephTremoulet closed D24117: Fix inliner funclet unwind memoization.
Sep 3 2016, 6:31 PM

Sep 2 2016

JosephTremoulet added inline comments to D24117: Fix inliner funclet unwind memoization.
Sep 2 2016, 6:08 PM
JosephTremoulet updated the diff for D24117: Fix inliner funclet unwind memoization.
  • Add assertions guarding against over-propagation of unwind dest token
Sep 2 2016, 6:04 PM
JosephTremoulet added inline comments to D24117: Fix inliner funclet unwind memoization.
Sep 2 2016, 10:04 AM

Sep 1 2016

JosephTremoulet added inline comments to D24117: Fix inliner funclet unwind memoization.
Sep 1 2016, 6:55 PM
JosephTremoulet updated the diff for D24117: Fix inliner funclet unwind memoization.
  • fix typo
  • fix bogus assertion, add testcase covering it
Sep 1 2016, 5:57 PM

Aug 31 2016

JosephTremoulet added inline comments to D24117: Fix inliner funclet unwind memoization.
Aug 31 2016, 8:26 PM
JosephTremoulet retitled D24117: Fix inliner funclet unwind memoization from to Fix inliner funclet unwind memoization.
Aug 31 2016, 6:50 PM

Feb 23 2016

JosephTremoulet accepted D17536: [WinEH] Don't inline an 'unwinds to caller' cleanupret into funclets which locally unwind.

LGTM

Feb 23 2016, 9:11 AM
JosephTremoulet added a comment to D17536: [WinEH] Don't inline an 'unwinds to caller' cleanupret into funclets which locally unwind.

HandleInlinedEHPad builds up the FuncletUnwindMap looking at the pre-inlining callee IR. Sharing it with the new call to getUnwindDestToken might be benign, but I'm not sure. I think it would be safer to use a separate FuncletUnwindMap for the new call. Probably also safer to compute the unwind dest in the caller before the code on line 1759 has had a chance to give the caller EH pad new uses in the partially-rewritten inlinee which might confuse the computation.

Feb 23 2016, 7:38 AM

Feb 4 2016

JosephTremoulet closed D16911: [RS4GC] Pass DenseMap by reference, NFC.
Feb 4 2016, 5:47 PM
JosephTremoulet retitled D16911: [RS4GC] Pass DenseMap by reference, NFC from to [RS4GC] Pass DenseMap by reference, NFC.
Feb 4 2016, 5:39 PM
JosephTremoulet added inline comments to D16513: [Unittest] Clean up formatting, NFC.
Feb 4 2016, 9:19 AM
JosephTremoulet added a comment to D16238: Preliminary: enable "spill on exception path" and "spill on normal path" RS4GC options.

FYI, I've split this out into constituent changes (locally). I think at this point it makes sense to hold off uploading them individually to Phabricator until they're ready for real review (for fear I'd lose track of things otherwise), but I do have them pushed up to my GitHub fork for my own sake, so if someone happens to want to look at the changes that way, they are:

Feb 4 2016, 8:16 AM
JosephTremoulet updated the diff for D16238: Preliminary: enable "spill on exception path" and "spill on normal path" RS4GC options.

cosmetic tidying

Feb 4 2016, 7:58 AM

Feb 3 2016

JosephTremoulet closed D16513: [Unittest] Clean up formatting, NFC.
Feb 3 2016, 9:15 AM

Feb 2 2016

JosephTremoulet updated the diff for D16238: Preliminary: enable "spill on exception path" and "spill on normal path" RS4GC options.

I went to create the spill slots up-front. Looking at the code after doing that, I realized it makes it more readable to pull all of the spill/fill insertion into the new pass, so that its workings are akin to the rematerialization pass. So I did that.

Feb 2 2016, 2:42 PM
JosephTremoulet updated the diff for D16513: [Unittest] Clean up formatting, NFC.

switch back to inline ctor, as that seems to be the consensus

Feb 2 2016, 2:25 PM