This is an archive of the discontinued LLVM Phabricator instance.

[libc][NFC] Add a death test API adaptation macro
ClosedPublic

Authored by michaelrj on Jan 28 2021, 4:14 PM.

Details

Summary

Fuchsia's zxtest has a slightly different death test definition, and
this macro makes our death test API work on Fuchsia.

Diff Detail

Event Timeline

michaelrj created this revision.Jan 28 2021, 4:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2021, 4:14 PM
michaelrj requested review of this revision.Jan 28 2021, 4:14 PM
sivachandra retitled this revision from [libc][NFC] add death test macro for Fuchsia to [libc][NFC] Add a death test API adaptation macro .Jan 28 2021, 4:23 PM
sivachandra edited the summary of this revision. (Show Details)

You need update all tests with EXPECT|ASSERT_DEATH.

michaelrj updated this revision to Diff 320006.Jan 28 2021, 5:07 PM
michaelrj retitled this revision from [libc][NFC] Add a death test API adaptation macro to [libc][NFC] Add a death test API adaptation macro.

update all of the EXPECT_DEATH calls

sivachandra accepted this revision.Feb 1 2021, 11:06 AM
This revision is now accepted and ready to land.Feb 1 2021, 11:06 AM
This revision was landed with ongoing or failed builds.Feb 1 2021, 11:19 AM
This revision was automatically updated to reflect the committed changes.